Date: Fri, 7 Dec 2007 12:11:01 -0500 From: Todd Wasson <tsw5@duke.edu> To: =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@deepcore.dk> Cc: "Julian H. Stacey" <jhs@berklix.org>, "Andrey V. Elsukov" <bu7cher@yandex.ru>, freebsd-current@FreeBSD.ORG, =?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@FreeBSD.ORG> Subject: Re: BETA4 installer doesn't attach my HDD controller; BETA3 did Message-ID: <4A85ADA7-1528-4164-8566-506DEFFE5EB0@duke.edu> In-Reply-To: <4759259A.3070000@deepcore.dk> References: <1B3A2410-9C2A-4126-AC92-8E38B4A0D79A@duke.edu> <200712061726.lB6HQCIu023253@fire.js.berklix.net> <C8EA53AF-B580-40D7-AFDB-E4F8C3DB8233@duke.edu> <4758FC14.2080606@yandex.ru> <4759259A.3070000@deepcore.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Julian, Andrey, and Soren, thank all of you for your help. I applied =20=
Soren's patch (as I just pulled it from the tree via csup) and the =20
problem appears to be resolved. I appreciate your assistance and the =20=
fast turnaround time on this.
Todd
On Dec 7, 2007, at 5:51 AM, S=F8ren Schmidt wrote:
> Andrey V. Elsukov wrote:
>> Todd Wasson wrote:
>>>> Todd Wasson wrote:
>>>>> I've got a Maxtor 6Y080L0 YAR41VW0 drive on a JMicron JMB368 =20
>>>>> UDMA133
>>>>> controller, and in the BETA4 installer the controller doesn't =20
>>>>> seem to
>>>>> be properly attaching, which leads to the drive not being =20
>>>>> found. The
>>>>> relevant sections from dmesg (as I'm not sure where else to look =20=
>>>>> while
>>>>> running the installer CD) are:
>>>>
>>>> Did you try "Safe Boot" key 3.
>>
>> I think this changes may create a regression:
>>
>> 1. the BETA3's version:
>>
>> ctlr->r_type2 =3D SYS_RES_MEMORY;
>> ctlr->r_rid2 =3D PCIR_BAR(5);
>> if ((ctlr->r_res2 =3D bus_alloc_resource_any(dev, =
ctlr->r_type2,
>> &ctlr->r_rid2, RF_ACTIVE))){
>> if ((error =3D ata_ahci_chipinit(dev)))
>> return error;
>> }
>> We have two checks here. Probably your controller doesn't allocate a
>> memory resource for the AHCI, but it works because it skips second
>> checks.
>>
>> 2. the BETA4's version:
>>
>> if ((error =3D ata_ahci_chipinit(dev)))
>> return error;
>>
>> In this version driver doesn't pass it. I've already sent patch
>> for test to your PR, but i attach it again.
>> May be Soren can comment it?
> Yeah, there's a bug allright, attached patch is the right way to fix =20=
> it, I'll commit when I get a few..
>
> -S=F8ren
>
>
> ? JMicrom-p1
> ? ich-sata-fix
> Index: ata-chipset.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> RCS file: /home/ncvs/src/sys/dev/ata/ata-chipset.c,v
> retrieving revision 1.209
> diff -u -r1.209 ata-chipset.c
> --- ata-chipset.c 26 Nov 2007 19:08:08 -0000 1.209
> +++ ata-chipset.c 7 Dec 2007 10:49:06 -0000
> @@ -2260,7 +2309,7 @@
> pci_write_config(dev, 0x40, 0x80c0a131, 4);
> pci_write_config(dev, 0x80, 0x01200000, 4);
>
> - if ((error =3D ata_ahci_chipinit(dev)))
> + if (ctlr->chip->cfg1 && (error =3D ata_ahci_chipinit(dev)))
> return error;
>
> ctlr->allocate =3D ata_jmicron_allocate;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4A85ADA7-1528-4164-8566-506DEFFE5EB0>