Date: Tue, 21 Oct 2003 16:40:57 -0700 (PDT) From: Maksim Yevmenkin <m_evmenkin@yahoo.com> To: "Simon L. Nielsen" <simon@FreeBSD.org> Cc: jhay@freebsd.org Subject: Re: [PATCH] connect bluetooth configs and examples to the build Message-ID: <20031021234057.85729.qmail@web40303.mail.yahoo.com> In-Reply-To: <20031021215707.GC393@arthur.nitro.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
Simon,
> > i'd like to commit attached patch. the purpose is to connect etc/bluetooth
> > and share/examples/netgraph/bluetooth to the build. please review and let
> > me know if i missed anything.
> >
> > Index: src/etc/bluetooth/Makefile
> > ===================================================================
> > RCS file: src/etc/bluetooth/Makefile
> > diff -N src/etc/bluetooth/Makefile
> > --- /dev/null 1 Jan 1970 00:00:00 -0000
> > +++ src/etc/bluetooth/Makefile 21 Oct 2003 20:20:03 -0000
> > @@ -0,0 +1,10 @@
> > +# $Id: Makefile,v 1.1 2003/10/20 16:48:45 max Exp $
> > +# $FreeBSD$
> > +
> > +FILESDIR= ${DESTDIR}/etc/bluetooth
>
> I'm rather sure that you shouldn't include DESTDIR, since bsd.files.mk
> does that.
got it. thanks for noticing this :)
> Also you should probably use the style from
> style.Makefile(5) for new Makefile's.
could you please be more specific? i took a quick look at style.Makefile(5)
page and could not find anything related to my case.
thanks,
max
__________________________________
Do you Yahoo!?
The New Yahoo! Shopping - with improved product search
http://shopping.yahoo.com
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20031021234057.85729.qmail>