Date: Tue, 19 Jan 2021 16:43:05 +0000 From: Jessica Clarke <jrtc27@freebsd.org> To: Oleksandr Tymoshenko <gonzo@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 248f0cabca75 - main - make maximum interrupt number tunable on ARM, ARM64, MIPS, and RISC-V Message-ID: <8FE79D0F-602A-4C98-893A-806E72ED991B@freebsd.org> In-Reply-To: <202101190036.10J0aj3O033256@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
On 19 Jan 2021, at 00:36, Oleksandr Tymoshenko <gonzo@FreeBSD.org> wrote: > @@ -142,21 +143,15 @@ static bool irq_assign_cpu = false; > #endif > #endif > > -/* > - * - 2 counters for each I/O interrupt. > - * - MAXCPU counters for each IPI counters for SMP. > - */ > -#ifdef SMP > -#define INTRCNT_COUNT (NIRQ * 2 + INTR_IPI_COUNT * MAXCPU) > -#else > -#define INTRCNT_COUNT (NIRQ * 2) > -#endif > +int intr_nirq = NIRQ; > +SYSCTL_UINT(_machdep, OID_AUTO, nirq, CTLFLAG_RDTUN, &intr_nirq, 0, > + "Number of IRQs"); Unsigned integer, given the SYSCTL_UINT? What's stopping us from dynamically resizing rather than forcing the user to use a tunable (which also means that, in practice, the limit will remain unchanged, because you want GENERIC kernels to work out of the box)? Jesshome | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?8FE79D0F-602A-4C98-893A-806E72ED991B>