Date: Wed, 21 Aug 2013 15:02:39 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Davide Italiano <davide@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org> Subject: Re: svn commit: r254616 - head/sys/dev/hwpmc Message-ID: <CAJ-VmonvLtaqxQx-rvJikwf0H5Ku8=ejQrRguNTdkBeesriddQ@mail.gmail.com> In-Reply-To: <CACYV=-Et5znyu_BR0gnnrOUJvN2DEDfOU_mwSmePRvBjrz%2BgFA@mail.gmail.com> References: <201308212147.r7LLlu6V016807@svn.freebsd.org> <CACYV=-FPEggceqBDv8XhEsCCByj3QnZsqsn66%2B8wcpnEVG8oQQ@mail.gmail.com> <CACYV=-Et5znyu_BR0gnnrOUJvN2DEDfOU_mwSmePRvBjrz%2BgFA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
i'll talk with you/hiren/{MANPAGE_PEOPLE} once my current run of "figuring
out what the hell" is done. That way the updates can be done in one big hit.
Thanks
-adrian
On 21 August 2013 14:59, Davide Italiano <davide@freebsd.org> wrote:
> On Wed, Aug 21, 2013 at 2:52 PM, Davide Italiano <davide@freebsd.org>
> wrote:
> > On Wed, Aug 21, 2013 at 2:47 PM, Adrian Chadd <adrian@freebsd.org>
> wrote:
> >> Author: adrian
> >> Date: Wed Aug 21 21:47:56 2013
> >> New Revision: 254616
> >> URL: http://svnweb.freebsd.org/changeset/base/254616
> >>
> >> Log:
> >> Change the name of this particular event to reflect the name used in
> >> Linux and Intel examples.
> >>
> >> Sourced:
> >>
> >> * https://github.com/andikleen/pmu-tools/blob/master/snb-client.csv
> >> * http://software.intel.com/en-us/comment/1747932#comment-1747932
> >>
> >> Note:
> >>
> >> * It's not currently in the Intel SDM; I need to chase down what's
> >> going on.
> >>
> >> Tested:
> >>
> >> * Sandy Bridge
> >>
> >> Modified:
> >> head/sys/dev/hwpmc/pmc_events.h
> >>
> >> Modified: head/sys/dev/hwpmc/pmc_events.h
> >>
> ==============================================================================
> >> --- head/sys/dev/hwpmc/pmc_events.h Wed Aug 21 21:30:56 2013
> (r254615)
> >> +++ head/sys/dev/hwpmc/pmc_events.h Wed Aug 21 21:47:56 2013
> (r254616)
> >> @@ -3304,7 +3304,7 @@ __PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RE
> >> IAP_EVENT_D2H_04H)
> \
> >> __PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RETIRED.XSNP_NONE",
> \
> >> IAP_EVENT_D2H_08H)
> \
> >> -__PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RETIRED.LLC_MISS",
> \
> >> +__PMC_EV_ALIAS("MEM_LOAD_UOPS_MISC_RETIRED.LLC_MISS",
> \
> >> IAP_EVENT_D4H_02H)
> \
> >> __PMC_EV_ALIAS("L2_TRANS.DEMAND_DATA_RD", IAP_EVENT_F0H_01H)
> \
> >> __PMC_EV_ALIAS("L2_TRANS.RFO", IAP_EVENT_F0H_02H)
> \
> >> @@ -3538,7 +3538,7 @@ __PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RE
> >> IAP_EVENT_D2H_08H)
> \
> >> __PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RETIRED.ALL",
> \
> >> IAP_EVENT_D2H_0FH)
> \
> >> -__PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_HIT_RETIRED.LLC_MISS",
> \
> >> +__PMC_EV_ALIAS("MEM_LOAD_UOPS_MISC_RETIRED.LLC_MISS", \
> >> IAP_EVENT_D4H_02H)
> \
> >> __PMC_EV_ALIAS("MEM_LOAD_UOPS_LLC_MISS_RETIRED.LOCAL_DRAM",
> \
> >> IAP_EVENT_D3H_01H)
> \
> >
> > Can you update the manpage as well?
> >
> > --
> > Davide
> >
> > "There are no solved problems; there are only problems that are more
> > or less solved" -- Henri Poincare
>
> Also for r254476, as already requested by Hiren, because everyone
> looks at the manpage to understand what metrice the event measures
> before running pmcstat, so having manpages update when new events are
> added is almost necessary.
>
> Thanks,
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmonvLtaqxQx-rvJikwf0H5Ku8=ejQrRguNTdkBeesriddQ>