Date: Fri, 22 Oct 2010 14:03:08 -0600 (MDT) From: Warner Losh <imp@bsdimp.com> To: dim@FreeBSD.org Cc: svn-src-head@FreeBSD.org, rdivacky@FreeBSD.org, src-committers@FreeBSD.org, svn-src-all@FreeBSD.org Subject: Re: svn commit: r214210 - head/sys/boot/i386/boot2 Message-ID: <20101022.140308.487226281.imp@bsdimp.com> In-Reply-To: <4CC1EBEB.2020309@FreeBSD.org> References: <201010221807.o9MI7LD8061657@svn.freebsd.org> <20101022.124640.74690513.imp@bsdimp.com> <4CC1EBEB.2020309@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <4CC1EBEB.2020309@FreeBSD.org>
Dimitry Andric <dim@FreeBSD.org> writes:
: On 2010-10-22 20:46, Warner Losh wrote:
: >> Avoid using memcpy() for copying 32bit chunks. This shrinks
: >> the resulting code a little.
: >
: > I think I put the memcpy code in when I was porting to ARM to reduce
: > the diffs since it is needed there...
: Due to alignment problems otherwise?
Yes. At the time it didn't make a difference to the size of boot2.
Now I know that we're looking for every byte to trim...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101022.140308.487226281.imp>