Date: Tue, 15 Feb 2005 01:19:20 +0900 From: Hajimu UMEMOTO <ume@FreeBSD.org> To: Alexey Zelkin <phantom@FreeBSD.org.ua> Cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include netdb.h src/lib/libc/net getaddrinfo.c Message-ID: <ygesm3z5d2v.wl%ume@mahoroba.org> In-Reply-To: <20050214160838.GA1414@phantom.cris.net> References: <200502141133.j1EBXC6D001449@repoman.freebsd.org> <ygeu0of5e4z.wl%ume@mahoroba.org> <20050214160838.GA1414@phantom.cris.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, >>>>> On Mon, 14 Feb 2005 18:08:38 +0200 >>>>> Alexey Zelkin <phantom@FreeBSD.org.ua> said: phantom> 1. This is optimization. Optimization for what? It is called at only error. phantom> 2. This is preparation to addition of NLS support for gai_strerror() Oh, it fine. However, I don't imagine why we need your previous change for NLS support. phantom> Actually, since gai_strerror() is exported function and only user phantom> of ai_errlist[], would not it be better to move these to separate phantom> source file ? It will make KAME integration for getaddrinfo.c phantom> much easier, IMHO. No, we were torn by EAI_* around RFC 2553 and RFC 3493. So, I don't want having difference against KAME here. Actually, your change is backward. See http://www.kame.net/dev/cvsweb2.cgi/kame/kame/kame/libinet6/getaddrinfo.c#rev1.102 Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ygesm3z5d2v.wl%ume>