Date: Wed, 10 Jun 2026 21:19:16 -0700 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Warner Losh <imp@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>, androvonx95 <androvonx95@tutamail.com> Subject: Re: git: 925f53682469 - main - improve renice user error messages Message-ID: <16487C94-005B-4151-B6FA-BD3FEBC1A00E@gmail.com> In-Reply-To: <6a295a32.3e002.31d3fa83@gitrepo.freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] > On Jun 10, 2026, at 5:36 AM, Warner Losh <imp@FreeBSD.org> wrote: > > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=925f53682469ea12c017b48114b16e8f1627fb0b > > commit 925f53682469ea12c017b48114b16e8f1627fb0b > Author: androvonx95 <androvonx95@tutamail.com> > AuthorDate: 2025-07-15 18:01:28 +0000 > Commit: Warner Losh <imp@FreeBSD.org> > CommitDate: 2026-06-10 12:35:02 +0000 > > improve renice user error messages > > Improve error handling for invalid user names and UIDs in renice: > - Use warnx() and err() for consistent error reporting > - Set errno = EINVAL for invalid input > - Provide clearer error messages for invalid user names and UIDs > - Add test cases for invalid user input > > Signed-off-by: androvonx95 <androvonx95@tutamail.com> > Reviewed by: imp > Pull Request: https://github.com/freebsd/freebsd-src/pull/1768 ... This commit is broken: - The test regexes don’t match what the program outputs. - A number of test cases were added, but not connected in `atf_init_test_cases`. - There’re some dead code paths/double warnx calls which add noise to the program output. I think it would be a good idea to revert the commit, fix the issues, then resubmit the change once the issues with the submission have been resolved. Thank you, -Enji PS Sorry for recommending you repro the issue with ghpr — this wouldn’t have likely happened had you not pushed changes that weren’t 100% tested/complete. [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkHfexGRJ3gYRdA2gGpE5DjPsNJgFAmoqN0QACgkQGpE5DjPs NJgi3A//a89QpPQIfDDN2G6wDMfObx3mS7rj0l8cj/mRJzr8/82qjDCaL6QjLMDv 94C0x3Th31pBkE7BAiwssOy5n2nUIk+AGWNU9e8WdA1KvIcFUxKUlF6DxCFL+lZ5 U2i/EWoMrEVYHPEk++kURuQOyL0pRR52WS6sSE7fsRN0M4KbEkyPbL16p10ftjhD Yv1ePZsoDvvapetYID+PLOAZDzdbkpY3VighvLDU36/MTfz1vvy3HzlBoCF0eM3x FEP0g+EG2uiJ2TDjrRkuXssjZxQCnIT33MytHSrzcIZ6Wzrzm/0ge7A0otxSHhIF UtddgfJEgi99R8VGIjiz7rkctYkl4BZ+meoQwP+2WZAyhwyht/Fce80b27TqIrNl 2W1/qico49Y9zZcIHYcr0lh95vLIdBfh+mtPiDFENUxCUv//a4Neuv2m0ZHx2MJP 3LKj6WxbLxh8OgKPzBYizcGJfmtoJayEuZfFTT5NB6/yKY9Vew9HzpCAHtQ2+Dru +pIlvxwqn/rTilX2HqMZ3SbCDWfDGAc+UscqmcLKc+f7fVR8L6v9zw/GMw9EG1eg nUJ2G5GBIUXWENr91Omx6SUwNvLsJD4ONDxwurDjNENA6t8/ja9YSYz8jmwAGsl0 wz4/yG8bLz3b9+At3n8qgqhT0Xqdxk63lbplgP/b9sExqBGRly0= =RAsP -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?16487C94-005B-4151-B6FA-BD3FEBC1A00E>