Date: Sat, 3 Aug 2013 14:21:02 -0700 From: Adrian Chadd <adrian@freebsd.org> To: Cedric GROSS <cg@cgross.info> Cc: freebsd-wireless@freebsd.org Subject: Re: [IWN] Reviw split 2 Message-ID: <CAJ-VmomdAvfGYEwo2M6%2BR4wqUA8BZTqo6NCZcBeKStaP96kziQ@mail.gmail.com> In-Reply-To: <003501ce908e$2e9d2750$8bd775f0$@info> References: <51f3f0ce.055a420a.2e1e.fffff220SMTPIN_ADDED_BROKEN@mx.google.com> <CAJ-VmokCVB5kNY44hJLbAfOb1DMSHmJAG3QTUZYhmPL1gHwMwA@mail.gmail.com> <002d01ce8c46$a13b23d0$e3b16b70$@info> <CAJ-Vmon4hMbgFKaWva3-HhcJv=eUXKwX7s0uPcD9Nu9g86QEbA@mail.gmail.com> <002701ce8e03$c033f640$409be2c0$@info> <CAJ-Vmo=yZXdKuXZ85bXs-uG2tAmcZFMAgFXCswnVBk2PUmaXfQ@mail.gmail.com> <002401ce8f5f$fc5ad780$f5108680$@info> <CAJ-VmoniUozz48U0MHhF4sAsrJt6sd06Q9UESRFG9kOXSB2ObQ@mail.gmail.com> <001001ce903b$e77a5f70$b66f1e50$@info> <CAJ-VmonRBrVCZu9dshSEiVxH9=0LhHdxr5tew4tsN1A5R9f0Sw@mail.gmail.com> <001e01ce907e$f1daf220$d590d660$@info> <CAJ-VmokSjs1gWJa0h6evb71Nf0=jNSLBMCW00EtAjinOmT69ig@mail.gmail.com> <003201ce9081$b401a270$1c04e750$@info> <CAJ-Vmo=YBzkcySqJxWhn0WWtbSrCsT41GO%2BBwYOvDHu2_A7KBQ@mail.gmail.com> <003501ce908e$2e9d2750$8bd775f0$@info>
next in thread | previous in thread | raw e-mail | index | archive | help
Nah, let's take it easier for now. Just leave the trace flags where they are in your diff, remove the flags check so the debug mask works the way it is, and submit a diff with _just_ the remaining debug flags line changes. That way we know what the required changes are, it will only bug people doing active testing (ie, you, me and -wireless) and we have the flags there for when we do sit down and figure out the right way to do trace debugging. Let's get these debug flags for trace in the tree, shorten the diff, and move onto the next set of structural changes. -adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-VmomdAvfGYEwo2M6%2BR4wqUA8BZTqo6NCZcBeKStaP96kziQ>