Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Nov 2001 11:38:33 -0800 (PST)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Peter Jeremy <peter.jeremy@alcatel.com.au>
Cc:        cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/i386/include atomic.h
Message-ID:  <XFMail.011121113833.jhb@FreeBSD.org>
In-Reply-To: <20011121075927.A74178@gsmx07.alcatel.com.au>

next in thread | previous in thread | raw e-mail | index | archive | help

On 20-Nov-01 Peter Jeremy wrote:
> On Mon, Nov 12, 2001 at 08:57:33AM -0800, John Baldwin wrote:
>>jhb         2001/11/12 08:57:33 PST
>>
>>  Modified files:
>>    sys/i386/include     atomic.h 
>>  Log:
>>  Use newer constraints for inline assembly for an operand that is both an
>>  input and an output by using the '+' modifier rather than listing the
>>  operand in both the input and output sections.
> 
> This change still leaves the non-memory operand's constraint as "ir"
> in all cases - this isn't correct for the char or short cases.  I have
> some old patches to fix this.

There are char and short registers and immediates in x86 asm.  The shorts will
make the assembler insert an extra byte to change the operand size, but it will
still compile.

> In any case, -stable also needs the change to use "+".

Yes, probably so.

> Peter

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.011121113833.jhb>