Date: Tue, 13 Aug 2013 16:54:48 -0400 From: Glen Barber <gjb@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r254224 - head/share/man/man7 Message-ID: <20130813205448.GC2241@glenbarber.us> In-Reply-To: <20130814.053554.1333869805065914360.hrs@allbsd.org> References: <201308111857.r7BIvRSq080970@svn.freebsd.org> <20130814.042557.877689080765344354.hrs@allbsd.org> <20130813195257.GA2241@glenbarber.us> <20130814.053554.1333869805065914360.hrs@allbsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--MnLPg7ZWsaic7Fhd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 14, 2013 at 05:35:54AM +0900, Hiroki Sato wrote: > gj> Why is get_rev_branch() redundant? >=20 > Because variables in get_rev_branch() are already defined in > src/release/Makefile, too. If one wants to use them in release.sh > for some reason, "make -VBRANCH" is preferable instead of duplicating > the same logic in Makefile to extract them from newvers.sh. This > script should not do the same job which Makefile does. >=20 > IMO, the default value of OSRELEASE is not needed here. It seems > used in RELSTRING, but it does not work (and even if it works, it > just generates the same default value). If we always need to > override the default value, Makefile should be fixed instead. >=20 Got it. I think (based on my local revision history) that this was added before the changes to Makefile to set the RELSTRING, when it was done in generate-release.sh. I'll remove it. Glen --MnLPg7ZWsaic7Fhd Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQEcBAEBCAAGBQJSCp0YAAoJEFJPDDeguUajpEoH/3jRw6GTgnRXKviG/GkTzMPc bNEHPymTdGVQyvRKCCVJM3Bx7p4R9Ky0nrpEju9RuewtZ+7sjn6jzayJO02QQyp2 zEx5bRpYNbkrA47Qyltp4KsWZg2V8wvBmVoDH17zP3yYpvnYS6K39coCkfjEOF3N evZFs7dvVRBHHDNfDdM+VjtIyPAG/twXhAKGOn+kUjY/PjcppJ3tL9BZtGA6oBlg DJLq9Uk+YFP9ckEHv1gam+amrPTyL8O1SqeMsfbBFbi6VbeL3CPcieF+4i7+cVt2 8m43X+l0f50bZiVwoCCe84H43vv+z7Z9ra27mBfNK8N4biu45wSIurTIfWB5lIM= =6fme -----END PGP SIGNATURE----- --MnLPg7ZWsaic7Fhd--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130813205448.GC2241>