Date: Tue, 17 Dec 2019 07:18:09 -0700 From: Warner Losh <imp@bsdimp.com> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r355737 - head/share/man/man9 Message-ID: <CANCZdfpONyZrttzSDbz1gB5x%2BdZdd1b-fTpi8LuLS7XrLb4yvw@mail.gmail.com> In-Reply-To: <201912170939.xBH9dFhD096828@gndrsh.dnsmgr.net> References: <CANCZdfrfBUUuxP-14DNy5-fwB5p0tCvcgPy_0N=s1OMbxEzoAg@mail.gmail.com> <201912170939.xBH9dFhD096828@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Dec 17, 2019 at 2:39 AM Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote: > > On Sun, Dec 15, 2019, 11:51 AM Rodney W. Grimes < > freebsd@gndrsh.dnsmgr.net> > > wrote: > > > > > > Author: imp > > > > Date: Fri Dec 13 22:32:05 2019 > > > > New Revision: 355737 > > > > URL: https://svnweb.freebsd.org/changeset/base/355737 > > > > > > > > Log: > > > > Better copyright advice > > > > > > > > Document the common practices around copyrights with "all rights > > > reserved" in > > > > them as new copyright notices get added. > > > > > > > > It's an open question qhether to point people at the fact that > since > > > the Berne > > > > convention was ratified, All rights reserved is largely obsolete. > > > > https://en.wikipedia.org/wiki/All_rights_reserved#Obsolescence > has the > > > > details. The committer's guide will be revised shortly, and it's > > > likely that's a > > > > better place for this discussion. If not, I'll add a blurb here. > > > > > > > > Reviewed by: jhb@, brooks@ > > > > Differential Review: https://reviews.freebsd.org/D22800 > > > > > > I object to the a review that specifically invites people to it, > > > is authored and committed in anything short of 24 hours and more > > > reasonable to actually ALLOW people time to repond of 72 hours. > > > > > > > The project has no fixed policies around reviews and giving time. Several > > people did look at it and approve it before I committed it. > > Then I'll be blunt, if your going to manually add me to a review > do not commit it until you have given me 72 hours to respond, if > you can not have that respect for my time to response DO NOT MANUALLY > INVITE ME TO YOUR REVIEW. > Sure, I'll respect your wishes, but I don't have to worry about that with anybody else. They just give the feedback when they get a chance to do so... Warner > > Having said that, this isn't like you've lost your ability to say > something > > forever now that this is in the tree. If you have suggestions to > > improvement, I'm all ears. > > > > I like your notion around (c) being noise, but I'll address that in the > > review. > > > > Warner > > > > > > Regards, > > > Rod > > > > > > > > > Better copyright advice > > > AcceptedPublic > > > Authored by imp on Fri, Dec 13, 12:33. > > > > > > > Modified: > > > > head/share/man/man9/style.9 > > > > > > > > Modified: head/share/man/man9/style.9 > > > > > > > > ============================================================================== > > > > --- head/share/man/man9/style.9 Fri Dec 13 22:04:13 2019 > > > (r355736) > > > > +++ head/share/man/man9/style.9 Fri Dec 13 22:32:05 2019 > > > (r355737) > > > > @@ -1,6 +1,5 @@ > > > > .\"- > > > > -.\" Copyright (c) 1995-2005 The FreeBSD Project > > > > -.\" All rights reserved. > > > > +.\" Copyright (c) 1995-2019 The FreeBSD Project > > > > .\" > > > > .\" Redistribution and use in source and binary forms, with or > without > > > > .\" modification, are permitted provided that the following > conditions > > > > @@ -26,7 +25,7 @@ > > > > .\" From: @(#)style 1.14 (Berkeley) 4/28/95 > > > > .\" $FreeBSD$ > > > > .\" > > > > -.Dd June 3, 2019 > > > > +.Dd December 13, 2019 > > > > .Dt STYLE 9 > > > > .Os > > > > .Sh NAME > > > > @@ -84,8 +83,32 @@ comments. > > > > Comments starting in columns other than the first are never > > > > considered license statements. > > > > Use the appropriate SPDX-License-Identifier line before the > copyright. > > > > +If the copyright assertion contains the phrase > > > > +.Dq Li "All Rights Reserved" > > > > +that should be on the same line as the word > > > > +.Dq Li "Copyright" . > > > > +You should not insert a new copyright line between an old > > > > +copyright line and this phrase. > > > > +Instead, you should insert a new copyright phrase after > > > > +a pre-existing > > > > +.Dq Li "All Rights Reserved" > > > > +line. > > > > +When making changes, it is acceptable to fold an > > > > +.Dq Li "All Rights Reserved" > > > > +line with each of the > > > > +.Dq Li "Copyright" > > > > +lines. > > > > +For files that have the > > > > +.Dq Li "All Rights Reserved" > > > > +line on the same line(s) as the word > > > > +.Dq Li "Copyright" , > > > > +new copyright assertions should be added last. > > > > +New > > > > +.Dq Li "Copyright" > > > > +lines should only be added when making substantial changes to the > file, > > > > +not for trivial changes. > > > > .Pp > > > > -After any copyright header, there is a blank line, and the > > > > +After any copyright and license comment, there is a blank line, and > the > > > > .Li $\&FreeBSD$ > > > > for non C/C++ language source files. > > > > Version control system ID tags should only exist once in a file > > > > > > > > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > > > > > -- > Rod Grimes > rgrimes@freebsd.org > On Tue, Dec 17, 2019 at 2:39 AM Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote: > > On Sun, Dec 15, 2019, 11:51 AM Rodney W. Grimes < > freebsd@gndrsh.dnsmgr.net> > > wrote: > > > > > > Author: imp > > > > Date: Fri Dec 13 22:32:05 2019 > > > > New Revision: 355737 > > > > URL: https://svnweb.freebsd.org/changeset/base/355737 > > > > > > > > Log: > > > > Better copyright advice > > > > > > > > Document the common practices around copyrights with "all rights > > > reserved" in > > > > them as new copyright notices get added. > > > > > > > > It's an open question qhether to point people at the fact that > since > > > the Berne > > > > convention was ratified, All rights reserved is largely obsolete. > > > > https://en.wikipedia.org/wiki/All_rights_reserved#Obsolescence > has the > > > > details. The committer's guide will be revised shortly, and it's > > > likely that's a > > > > better place for this discussion. If not, I'll add a blurb here. > > > > > > > > Reviewed by: jhb@, brooks@ > > > > Differential Review: https://reviews.freebsd.org/D22800 > > > > > > I object to the a review that specifically invites people to it, > > > is authored and committed in anything short of 24 hours and more > > > reasonable to actually ALLOW people time to repond of 72 hours. > > > > > > > The project has no fixed policies around reviews and giving time. Several > > people did look at it and approve it before I committed it. > > Then I'll be blunt, if your going to manually add me to a review > do not commit it until you have given me 72 hours to respond, if > you can not have that respect for my time to response DO NOT MANUALLY > INVITE ME TO YOUR REVIEW. > > > > Having said that, this isn't like you've lost your ability to say > something > > forever now that this is in the tree. If you have suggestions to > > improvement, I'm all ears. > > > > I like your notion around (c) being noise, but I'll address that in the > > review. > > > > Warner > > > > > > Regards, > > > Rod > > > > > > > > > Better copyright advice > > > AcceptedPublic > > > Authored by imp on Fri, Dec 13, 12:33. > > > > > > > Modified: > > > > head/share/man/man9/style.9 > > > > > > > > Modified: head/share/man/man9/style.9 > > > > > > > > ============================================================================== > > > > --- head/share/man/man9/style.9 Fri Dec 13 22:04:13 2019 > > > (r355736) > > > > +++ head/share/man/man9/style.9 Fri Dec 13 22:32:05 2019 > > > (r355737) > > > > @@ -1,6 +1,5 @@ > > > > .\"- > > > > -.\" Copyright (c) 1995-2005 The FreeBSD Project > > > > -.\" All rights reserved. > > > > +.\" Copyright (c) 1995-2019 The FreeBSD Project > > > > .\" > > > > .\" Redistribution and use in source and binary forms, with or > without > > > > .\" modification, are permitted provided that the following > conditions > > > > @@ -26,7 +25,7 @@ > > > > .\" From: @(#)style 1.14 (Berkeley) 4/28/95 > > > > .\" $FreeBSD$ > > > > .\" > > > > -.Dd June 3, 2019 > > > > +.Dd December 13, 2019 > > > > .Dt STYLE 9 > > > > .Os > > > > .Sh NAME > > > > @@ -84,8 +83,32 @@ comments. > > > > Comments starting in columns other than the first are never > > > > considered license statements. > > > > Use the appropriate SPDX-License-Identifier line before the > copyright. > > > > +If the copyright assertion contains the phrase > > > > +.Dq Li "All Rights Reserved" > > > > +that should be on the same line as the word > > > > +.Dq Li "Copyright" . > > > > +You should not insert a new copyright line between an old > > > > +copyright line and this phrase. > > > > +Instead, you should insert a new copyright phrase after > > > > +a pre-existing > > > > +.Dq Li "All Rights Reserved" > > > > +line. > > > > +When making changes, it is acceptable to fold an > > > > +.Dq Li "All Rights Reserved" > > > > +line with each of the > > > > +.Dq Li "Copyright" > > > > +lines. > > > > +For files that have the > > > > +.Dq Li "All Rights Reserved" > > > > +line on the same line(s) as the word > > > > +.Dq Li "Copyright" , > > > > +new copyright assertions should be added last. > > > > +New > > > > +.Dq Li "Copyright" > > > > +lines should only be added when making substantial changes to the > file, > > > > +not for trivial changes. > > > > .Pp > > > > -After any copyright header, there is a blank line, and the > > > > +After any copyright and license comment, there is a blank line, and > the > > > > .Li $\&FreeBSD$ > > > > for non C/C++ language source files. > > > > Version control system ID tags should only exist once in a file > > > > > > > > > > -- > > > Rod Grimes > > > rgrimes@freebsd.org > > > > > -- > Rod Grimes > rgrimes@freebsd.org >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpONyZrttzSDbz1gB5x%2BdZdd1b-fTpi8LuLS7XrLb4yvw>