Date: Tue, 6 May 2014 07:16:55 -0600 From: Warner Losh <imp@bsdimp.com> To: Stefan Esser <se@freebsd.org> Cc: "current@freebsd.org" <current@freebsd.org>, Trond.Endrestol@fagskolen.gjovik.no Subject: Re: buildworld fails (missing /usr/share/mk/src.opts.mk) Message-ID: <B33911D1-AFD8-491F-A59D-33C3E9DE1696@bsdimp.com> In-Reply-To: <5368D7F1.4040009@freebsd.org> References: <5368B0C5.6040309@freebsd.org> <5368C675.1070700@freebsd.org> <alpine.BSF.2.00.1405061344040.27459@mail.fig.ol.no> <5368D7F1.4040009@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On May 6, 2014, at 6:39 AM, Stefan Esser <se@freebsd.org> wrote: > Am 06.05.2014 13:44, schrieb Trond Endrestøl: >> On Tue, 6 May 2014 13:24+0200, Stefan Esser wrote: >>> Am 06.05.2014 11:52, schrieb Stefan Esser: >>>> Hi Warner, >>>> >>>> as already reported by Jenkins, HEAD does not build. >>>> >>>> Seems that this is caused by src.opts.mk missing in /usr/share/mk >>>> during the cleandir phase. I guess this is kind of a bootstrap >>>> issue - the definitions are looked up in the installed base, not >>>> in the src tree - but did not verify this assumption. >>>> >>>> A work-around is to manually install src.opts.mk: >>>> >>>> # make -C /usr/src/share/mk install >>>> >>>> (which might deserve an UPDATING entry). Falling back on the file >>>> in the src directory might be a better solution ... >>>> >>>> Regards, STefan >>> >>> Following up to my earlier mail: >>> >>> The diagnosis was wrong - the main Makefiles include src.opts.mk from >>> the source directory. But two sub-ordinate Makefiles missed to include >>> the new options file (sys/conf/kmod.mk and sys/modules/drm2/Makefile). >>> >>> I committed a fix/work-around to stop the flood of tinderbox messages >>> (r265433). >> >> tinderbox still complains about usr.bin/bmake/Makefile.inc. > > Hmmm, I managed to buildworld -HEAD after this patch, but it is > possible, that I had src.opts.mk installed in /usr/share/mk when > I started the build. > > (I later deleted it, to be sure that the version in the source > directory was found and used when building modules, which the > commit actually fixed.) > > I guess the remaining problem is caused by > > .include "src.opts.mk" > > in line 3 of src/usr.bin/bmake/Makefile.inc > > Changing this line to read ".include <src.opts.mk>" seems to fix > it on my system. > > --- usr.bin/bmake/Makefile.inc~ > +++ usr.bin/bmake/Makefile.inc > @@ -1,6 +1,6 @@ > # $FreeBSD$ > > -.include "src.opts.mk" > +.include <src.opts.mk> > > .if defined(.PARSEDIR) > # make sure this is available to unit-tests/Makefile > > It is possible, that the build will still fail at a latter stage, > though (buildworld is still running). > > I committed the above patch, since it gets buildworld through the > bmake subdirectory at least (r265436). If buildworld fails again, > then I'll commit any further missing fixes in one go. I'll know > in some 20 minutes. What is your source system? This is absolutely the wrong change, and shouldn’t be necessary at all. These changes survived a universe run and a few build worlds on other systems. Warner [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJTaODHAAoJEGwc0Sh9sBEAnUEP/Rwccw9ZauYWlsPfixxT/QRH BV0Zl5AkIV+wLJtrajjU3gOt3Omj243l997AfQkkYhHOMTfEfDIW+2qPCQMYczwV 6xXW32PgtWSblNOvEoxWXV84kBqbWBPZvoa7rslemOrK1oDAJTR+oT+CoBoDhcCH jPbay7IhDT6c6AgbBDN6Dy5Iwjs6n10fHXwObHpIx2JHuK17+/1MRvtRPantpcxL MLtHtDCcJ23wRbFXf8FdBcHE7osdX5Q6iKekebIFEJGMqv5C/c66LnaqKHwp8s1E BsJwdHSNBVr2wVfrUwv8Xxl1SvUzcZiCPLVWx156Ed2YPX9WjP+KpZLsx418oV37 9t3jglDSVgk1bNktzdcY2gB0Jztm9Xu+tlJHjsWlWf5IwT/TfK+vttsuYk4Utwbc HwcWTDOGnzX3jO7AiaDDtUeOz5+QVwGJ7bIY3/hHEsrhAtQWXGLB38Mivm32OR4k 6zvG6YRGE3s73XpeQLYGCfSYEeNbtN1W0a4FJOdDSsiLKW0RtryFLLyh+InBFG4W vdWp0KQAlJ6j25tai0n3CgsQ+CHbFO7I33Rbjjqb5ksirljajJrsDyowK2s97qxS JL41octPBF6Hdy+/8Ritkv4oo6M8IqupLMMMPQ4dTEjYoetBv+VMr+mVx56Je0eR mJ1KvDOFmY0Ig9yv1AGJ =Hfq0 -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?B33911D1-AFD8-491F-A59D-33C3E9DE1696>