Date: Sat, 27 Dec 2008 21:35:30 -0800 From: Alfred Perlstein <alfred@freebsd.org> To: Scott Long <scottl@samsco.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "mav@freebsd.org" <mav@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "M. Warner Losh" <imp@bsdimp.com> Subject: Re: svn commit: r186182 - head/sys/dev/ata Message-ID: <20081228053530.GF18389@elvis.mu.org> In-Reply-To: <72A0CF67-F521-4C4B-955D-A80A77CC1165@samsco.org> References: <4947D474.9040802@samsco.org> <20081216.101038.1172765453.imp@bsdimp.com> <4947F363.4010909@samsco.org> <20081216.120412.1346820326.imp@bsdimp.com> <20081227003826.GV18389@elvis.mu.org> <72A0CF67-F521-4C4B-955D-A80A77CC1165@samsco.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Scott Long <scottl@samsco.org> [081226 18:34] wrote: > > On Dec 26, 2008, at 5:38 PM, Alfred Perlstein <alfred@freebsd.org> > wrote: > > > >Easy enough to stash a "once" varible in the generic device struct > >and warn when returning from an isr when INVARIANTS or something is > >turned on. > > > >Then you'd only get one warning per device once it happens. > > > > > > I prefer to do nothing. It's not unsafe or erroneous to access cfg > registers. But if some kind of message does get added, I insist that > it drop all pretenses and say, "you're too poor to run freebsd, come > back when you can afford better hardware.". :) Well that could be the result of a driver that has a "bug" that makes it access cfg space when it does not need to, as what seems to have just been fixed. -- - Alfred Perlstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081228053530.GF18389>