Date: Thu, 11 Dec 2014 01:05:42 -0800 From: Mark Johnston <markj@FreeBSD.org> To: "Andrey V. Elsukov" <ae@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r275695 - head/sys/netinet6 Message-ID: <20141211090542.GA34208@raichu> In-Reply-To: <5489597C.80707@FreeBSD.org> References: <201412110041.sBB0ftwC030057@svn.freebsd.org> <5489597C.80707@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 11, 2014 at 11:44:44AM +0300, Andrey V. Elsukov wrote: > On 11.12.2014 03:41, Mark Johnston wrote: > > Author: markj > > Date: Thu Dec 11 00:41:54 2014 > > New Revision: 275695 > > URL: https://svnweb.freebsd.org/changeset/base/275695 > > > > Log: > > Fix a bug in r266857: nd6_dad_find() must return NULL if it doesn't find > > a matching element in the DAD queue. > > If there was no matching element, TAILQ_FOREACH will stop the loop with > dp == NULL. If there is bug somewhere, it isn't here. You're right - sorry for the noise. :( I somehow managed to convince myself that TAILQ_FOREACH() wouldn't set dp to NULL at end of a non-empty list. I'll revert the change now.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141211090542.GA34208>