Date: Thu, 25 Sep 2014 11:30:50 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Adrian Chadd <adrian@freebsd.org> Cc: "freebsd-arch@freebsd.org" <freebsd-arch@freebsd.org> Subject: Re: KASSERT_WARN for asserting malloc(M_WAITOK) not in a non-sleepable thread Message-ID: <5424433A.20809@FreeBSD.org> In-Reply-To: <CAJ-Vmok5Xaa6aZvfL1GoW8C==dY47P=vKAEZhu16JhHjV%2BTk9g@mail.gmail.com> References: <54236CD6.4050807@FreeBSD.org> <CACYV=-Eg69AQ72DOGppPSL7whJVCdcNg-auhBZ771iG7DfPdAw@mail.gmail.com> <5424392D.9030201@FreeBSD.org> <CAJ-Vmok5Xaa6aZvfL1GoW8C==dY47P=vKAEZhu16JhHjV%2BTk9g@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --V60Dxl31Sv7EgWsAKel1WTptM704eex7J Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 9/25/2014 11:14 AM, Adrian Chadd wrote: > Hi, >=20 > Please bring in KASSERT_WARN(). >=20 > I'm grown up enough to use KASSERT_WARN() along with handling the > invariant check myself in code. Having KASSERT_WARN() means I can add > in this rather than printf()s or device_printf()'s with various knobs > to remove it. >=20 > (This is absolutely _not_ the "should KASSERT() optionally just log" > argument. I'm not going to get into that a second time.) Agreed on this 2nd point. I am against that. Plus we already have debug.kassert.log_panic_at to effectively do that. >=20 >=20 > -a >=20 >=20 --=20 Regards, Bryan Drewery --V60Dxl31Sv7EgWsAKel1WTptM704eex7J Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJUJEM6AAoJEDXXcbtuRpfPA64H/0nIdIOMWU/sXHg8W2yW/nXQ mzf/odn6i4a+nXrevhAFwZsgmSQ0lEBF8UIq1hMSCnjuqz8Lsg8htF8ixfO5sqHn oGPKZPPq9c2SIt4VgeULLZ8RDlsujq6L2HehilFefuHuzgDV9Qf45bBgSSpBnZlS 82bL8qofK7B4gkvR+gHJa7I3iNO1jFiEcuRt29q4u7hL1sIg8XHWCgz4RlrtMskc HMxxxAuPrwtN27U8TQI3KKB1SIyNvD66/gH+Qzix/gwOfvhX3rrIQ+J5s6mfJIlS 7UVM5+6cCBtSBVaZupWKuVY7ToHXYx9dtrXQ9pE6vo3CDZKtmEUQdDrINIBOFdM= =Y0sM -----END PGP SIGNATURE----- --V60Dxl31Sv7EgWsAKel1WTptM704eex7J--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5424433A.20809>