Date: Tue, 13 Jul 2004 20:04:30 -0400 From: Garance A Drosihn <drosih@rpi.edu> To: Marcel Moolenaar <marcel@xcllnt.net> Cc: current@freebsd.org Subject: Re: CVSUP and 5.2.1 RELEASE Message-ID: <p06110417bd1a257b4447@[128.113.24.47]> In-Reply-To: <20040713232214.GA9507@dhcp50.pn.xcllnt.net> References: <26075.1089753893@critter.freebsd.dk> <p06110415bd1a0dedbf1c@[128.113.24.47]> <20040713232214.GA9507@dhcp50.pn.xcllnt.net>
next in thread | previous in thread | raw e-mail | index | archive | help
At 4:22 PM -0700 7/13/04, Marcel Moolenaar wrote:
>On Tue, Jul 13, 2004 at 06:23:38PM -0400, Garance A Drosihn wrote:
>>
>> a) how about if we print a warning and exit if DESTDIR is
>> not defined? Are there "important" uses of `make world'
>> which do not use DESTDIR?
>
>My thoughts exactly. See attached patch.
I imagine we could debate the best wording to use for the warning
message, but I do think this patch would be an improvement for our
users. If it saves a few users from a trashed system, it will be
a valuable change. In my quick testing, it seemed to do the right
things.
One other thing we might want to change is the part where we:
# Set a reasonable default
.MAIN: all
I am not so sure that is a reasonable default. Someone who roams
into /usr/src and types a plain `make' should probably be told to
read the documentation for what to do. However, this does not
bother me much. I think `make world' is the bigger issue.
--
Garance Alistair Drosehn = gad@gilead.netel.rpi.edu
Senior Systems Programmer or gad@freebsd.org
Rensselaer Polytechnic Institute or drosih@rpi.edu
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p06110417bd1a257b4447>