Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Sep 2002 15:32:11 +0100
From:      Tony Finch <dot@dotat.at>
To:        Juli Mallett <jmallett@FreeBSD.org>
Cc:        Tony Finch <fanf@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/share/man/man9 style.9
Message-ID:  <20020910153211.E14317@chiark.greenend.org.uk>
In-Reply-To: <20020910071126.B44916@FreeBSD.org>; from jmallett@FreeBSD.org on Tue, Sep 10, 2002 at 07:11:26AM -0700
References:  <200209101054.g8AAseoS004374@freefall.freebsd.org> <20020910071126.B44916@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Sep 10, 2002 at 07:11:26AM -0700, Juli Mallett wrote:
> 
> Any chance of us adopting the Mach (and Lites) policy of doing
> <sys/macro_help.h> (actually <mach/macro_help.h>), and having some
> macros like
> 
> #define	MACRO_BEGIN	do {
> #define	MACRO_END	} while(0)	/* or with a ; if you like that */
> 
> ?

I think this goes against the general policy in style(9) of assuming
that the readers and writers of the code know C and its idioms. It
also reduces portability. It misses out the other kinds of bracketing
that macros need to do, depending on whether they are expressions or
declarations as well as statements.

Tony.
-- 
f.a.n.finch <dot@dotat.at> http://dotat.at/
FISHER: EAST 5 OR 6, BECOMING VARIABLE, MAINLY EAST, 3 OR 4 IN SOUTH. THUNDERY
SHOWERS. MODERATE OR GOOD.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020910153211.E14317>