Date: Thu, 6 Jan 2000 08:50:07 +0100 (CET) From: Soren Schmidt <sos@freebsd.dk> To: green@FreeBSD.org (Brian Fundakowski Feldman) Cc: current@FreeBSD.org Subject: Re: ATA atapi-all.c problems/fixes/cleanups Message-ID: <200001060750.IAA73510@freebsd.dk> In-Reply-To: <Pine.BSF.4.10.10001051827570.2363-100000@green.dyndns.org> from Brian Fundakowski Feldman at "Jan 5, 2000 06:50:45 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
It seems Brian Fundakowski Feldman wrote:
> How about this? It's mostly the changes in your patch, but it also takes
> into account non-int{8,16}_t-sizing/alignment. It also takes care of the
> truncation problem when you use outsl and insl, as part of that. Please
> review it, as I think it should be the right thing to do.
Hmm, sortof. In the real world we should newer ever see partial
transfers, they should always be of N * DEV_BSIZE, so this is
a bitt overkill. However some of the internal ATAPI handling
use odd sizes for modes etc, but they are all at least 16 bit
aligned, so 8 bit alignment is not needed, I'll have to check
if we need 16 bit alignment, I can't remember ofhand...
-Søren
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200001060750.IAA73510>