Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 19 Oct 2008 15:47:12 +0300
From:      Kostik Belousov <kostikbel@gmail.com>
To:        Roman Divacky <rdivacky@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r184058 - in head/sys: amd64/linux32 compat/linux i386/linux
Message-ID:  <20081019124711.GR7782@deviant.kiev.zoral.com.ua>
In-Reply-To: <20081019124054.GA25779@freebsd.org>
References:  <200810191002.m9JA2Q5N040016@svn.freebsd.org> <20081019124054.GA25779@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--tHTlq+1i+J693gRP
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Oct 19, 2008 at 02:40:54PM +0200, Roman Divacky wrote:
> On Sun, Oct 19, 2008 at 10:02:26AM +0000, Konstantin Belousov wrote:
> > Author: kib
> > Date: Sun Oct 19 10:02:26 2008
> > New Revision: 184058
> > URL: http://svn.freebsd.org/changeset/base/184058
> >=20
> > Log:
> >   Correctly fill siginfo for the signals delivered by linux tkill/tgkil=
l.
> >   It is required for async cancellation to work.
> >  =20
> >   Fix PROC_LOCK leak in linux_tgkill when signal delivery attempt is ma=
de
> >   to not linux process.
> >  =20
> >   Do not call em_find(p, ...) with p unlocked.
> >  =20
> >   Move common code for linux_tkill() and linux_tgkill() into
> >   linux_do_tkill().
> >  =20
> >   Change linux siginfo_t definition to match actual linux one. Extend
> >   uid fields to 4 bytes from 2. The extension does not change structure
> >   layout and is binary compatible with previous definition, because i386
> >   is little endian, and each uid field has 2 byte padding after it.
>   =20
> does it fix the test case Nicolas provided? It didnt for me when I tried
> this patch...
As far as I got it from conversation with Dmitry, cancellation still does
not work. This patch is a required cleanup anyway.

>=20
> >   Reported by:	Nicolas Joly <njoly pasteur fr>
>=20
> might be of some interest for someone... njoly of netbsd :)
Point taken.

--tHTlq+1i+J693gRP
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (FreeBSD)

iEYEARECAAYFAkj7LE8ACgkQC3+MBN1Mb4g6+gCfUZxLcpHfhZmWzsUvrJksEccF
8koAoIZm6EXhtnLY5LnvHx7kG6b9l1Eb
=6MrZ
-----END PGP SIGNATURE-----

--tHTlq+1i+J693gRP--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081019124711.GR7782>