Date: Wed, 24 Sep 2025 15:27:13 -0700 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Warner Losh <imp@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: 2352b89d2f73 - main - nanobsd: Fix regressions from last cleanup Message-ID: <9DCA5700-4BD1-4C7C-9510-B0A79D41265E@gmail.com> In-Reply-To: <202509241644.58OGio1p048008@gitrepo.freebsd.org> References: <202509241644.58OGio1p048008@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Sep 24, 2025, at 9:44=E2=80=AFAM, Warner Losh <imp@FreeBSD.org> = wrote: >=20 > The branch main has been updated by imp: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D2352b89d2f732e3fa33fbd494267f0d4= cb917e51 >=20 > commit 2352b89d2f732e3fa33fbd494267f0d4cb917e51 > Author: Warner Losh <imp@FreeBSD.org> > AuthorDate: 2025-09-24 15:43:42 +0000 > Commit: Warner Losh <imp@FreeBSD.org> > CommitDate: 2025-09-24 15:43:42 +0000 >=20 > nanobsd: Fix regressions from last cleanup >=20 > c99bb5747f5e changed ( ) grouping into { }, but in these cases we = chdir > and depended on the subshell not changing it for the caller. = Restore the > old behavior. It seems to work w/o this change, true, but the old = code > was intentionally like this. >=20 > Fixes: c99bb5747f5e > Sponsored by: Netflix Thank you for fixing my faux pas Warner :/. I was actually considering = leaving the curly braces in place and just adding ellipses around the = affected instructions (it would have made the sub-shell scope explicit), = but this is a great fix too. -Enji=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9DCA5700-4BD1-4C7C-9510-B0A79D41265E>