Date: Sun, 15 Dec 1996 09:49:28 +0800 From: Peter Wemm <peter@spinner.DIALix.COM> To: Nate Williams <nate@mt.sri.com> Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/boot/rawboot Makefile Message-ID: <199612150149.JAA18365@spinner.DIALix.COM> In-Reply-To: Your message of "Sat, 14 Dec 1996 18:42:20 MST." <199612150142.SAA26642@rocky.mt.sri.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Nate Williams wrote: > Peter Wemm writes: > > peter 96/12/14 17:25:55 > > > > Modified: sys/i386/boot/rawboot Makefile > > Log: > > Add missing -I so that probe_keyboard.c can find <i386/isa/kbdio.h>. :-( > > (Why, oh why did this include file end up in isa/ rather than include/ ?) > > Because it's supposed to be only used by isa drivers. ;) > > Nate .. and it wouldn't need to be used if the keyboard IO port definitions were not ripped out of <machine/cons.h>. The boot code needs to know the port addresses. Those should have stayed in cons.h, the prototypes in kbdio.h are only useful to users of kbdio.c (probe_keyboard doesn't use kbdio.c). Cheers, -Peter
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199612150149.JAA18365>