Date: Fri, 07 Oct 2005 23:30:25 -0600 (MDT) From: "M. Warner Losh" <imp@bsdimp.com> To: yar@comp.chem.msu.su Cc: cvs-src@FreeBSD.org, glebius@FreeBSD.org, cvs-all@FreeBSD.org, bde@zeta.org.au, src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/conf options src/sys/dev/em if_em.c src/sys/dev/firewire if_fwe.c if_fwip.c src/sys/dev/fxp if_fxp.c src/sys/dev/ixgb if_ixgb.c src/sys/dev/nge if_nge.c src/sys/dev/re if_re.c src/sys/dev/vge if_vge.c src/sys/kern kern_clock.c ... Message-ID: <20051007.233025.00238018.imp@bsdimp.com> In-Reply-To: <20051008044623.GA2392@comp.chem.msu.su> References: <200510051009.j95A9HpC024040@repoman.freebsd.org> <20051005230120.B51543@delplex.bde.org> <20051008044623.GA2392@comp.chem.msu.su>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20051008044623.GA2392@comp.chem.msu.su>
Yar Tikhiy <yar@comp.chem.msu.su> writes:
: On Wed, Oct 05, 2005 at 11:01:47PM +1000, Bruce Evans wrote:
: > On Wed, 5 Oct 2005, Gleb Smirnoff wrote:
: >
: > >glebius 2005-10-05 10:09:17 UTC
: > >
: > > FreeBSD src repository
: > >
: > > Modified files:
: > > sys/conf options
: > > sys/dev/em if_em.c
: > > sys/dev/firewire if_fwe.c if_fwip.c
: > > sys/dev/fxp if_fxp.c
: > > sys/dev/ixgb if_ixgb.c
: > > sys/dev/nge if_nge.c
: > > sys/dev/re if_re.c
: > > sys/dev/vge if_vge.c
: > > sys/kern kern_clock.c kern_poll.c
: > > sys/net netisr.c
: > > sys/pci if_dc.c if_rl.c if_sf.c if_sis.c if_ste.c
: > > if_vr.c if_xl.c
: > > Log:
: > > - Don't pollute opt_global.h with DEVICE_POLLING and introduce
: > > opt_device_polling.h
: > > - Include opt_device_polling.h into appropriate files.
: > > - Embrace with HAVE_KERNEL_OPTION_HEADERS the include in the files that
: > > can be compiled as loadable modules.
: > >
: > > Reviewed by: bde
: >
: > Requested too. Thanks.
:
: According to this scheme, is every opt_*.h inclusion to be wrapped
: in "ifdef HAVE_KERNEL_OPTION_HEADERS" eventually?
I sure hope not... this seems like a step backwards...
Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051007.233025.00238018.imp>