Date: Fri, 17 Apr 1998 22:00:31 -0700 From: Julian Elischer <julian@whistle.com> To: Peter Wemm <peter@netplex.com.au> Cc: "Dag-Erling C. Smxf8rgrav" <des@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, cvs-sys@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/dpt dpt_control.c src/sys/gnu/ext2fs... Message-ID: <3538336F.41C67EA6@whistle.com> References: <199804180411.MAA16043@spinner.netplex.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
Peter Wemm wrote: > > "Dag-Erling C. Sm\xf8rgrav" wrote: > > des 1998/04/17 15:37:20 PDT > > > > Modified files: > > sys/dev/dpt dpt_control.c > > sys/gnu/ext2fs COPYRIGHT.INFO ext2_alloc.c ext2_vnops.c > [..] > > sys/ufs/ufs ufs_vnops.c > > Log: > > Seventy-odd "its" / "it's" typos in comments fixed as per kern/6108. > > What the hell??? I don't call this "fixing typos", as far as I can tell, > most of these changes have broken the correct usage. > > eg: here, we are talking about the device's softc: > +++ dpt_control.c 1998/03/23 10:49:01 > @@ -175,7 +175,7 @@ > > /** > * Given a minor device number, > - * return the pointer to it's softc structure > + * return the pointer to its softc structure sorry to contradict you Peter but this is the trick.. "its" is a single word, the same as: "his" and "her" as in: his cat, her cat, its cat the other version, e.g. "Joh's crow" or "John's VM code", shouldn't be confused with this.. why schools never explain it in this way I'll never understand. it took me years till someone explained this to me so clearly.. Until then I'd assumed.. "Sue's cakes", "John's cat", "it's softc" but that's wrong. "it's" is soley for the contraction "it is". julian > */ > > static INLINE dpt_softc_t * > > eg: here we are talking about the card's EEROM. > +++ if_ed.c 1998/03/23 11:05:46 > @@ -676,7 +676,7 @@ > #endif > DELAY(100); > outb(sc->asic_addr + ED_WD_MSR, inb(sc->asic_addr + ED_WD_MSR) & ~ED_WD_ > MSR_RST); > - /* wait in the case this card is reading it's EEROM */ > + /* wait in the case this card is reading its EEROM */ > DELAY(5000); > > sc->vendor = ED_VENDOR_WD_SMC; > > And so on... > > Just because a PR is submitted, it doesn't mean it's right. If they were > always right, there would be an automatic patch application process on PR > submission. > > -Peter
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3538336F.41C67EA6>