Date: Tue, 14 Oct 2014 23:38:23 -0400 From: Ed Maste <emaste@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: =?UTF-8?Q?Olivier_Cochard=2DLabb=C3=A9?= <olivier@cochard.me>, "George V. Neville-Neil" <gnn@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r272906 - in head/sys: conf libkern netpfil/pf sys Message-ID: <CAPyFy2CDSwLkTtPFj70tw2iuDam3rS4yFNri=pX0w7_58UYMoA@mail.gmail.com> In-Reply-To: <20141015030455.GC73266@FreeBSD.org> References: <201410101926.s9AJQRY1049602@svn.freebsd.org> <CA%2Bq%2BTcpt0zEbgu_LndZb4dzh=xykHvppeykuiG6P9cTJgDGeWw@mail.gmail.com> <20141015030455.GC73266@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 14 October 2014 23:04, Gleb Smirnoff <glebius@freebsd.org> wrote: > > Look at results at the end of email. Guess what -j and -m mean. I > want either proving me doing the test wrong, or backing the change > out ASAP. It looks like there is indeed an error in the test: > h = murmur3_aligned_32((uint32_t *)&key[i], > sizeof(struct pf_state_key_cmp)/sizeof(uint32_t), murmur3's size argument is bytes, not uint32_ts, so the test is only hashing the first 1/4 of the keys.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAPyFy2CDSwLkTtPFj70tw2iuDam3rS4yFNri=pX0w7_58UYMoA>