Date: Tue, 12 Apr 2011 01:59:33 GMT From: Eitan Adler <lists@eitanadler.com> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/156340: [patch] [bsd.port.mk] reaper of the dead: are three variable defintions needed Message-ID: <201104120159.p3C1xXcv061142@red.freebsd.org> Resent-Message-ID: <201104120200.p3C20MjF036653@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 156340
>Category: misc
>Synopsis: [patch] [bsd.port.mk] reaper of the dead: are three variable defintions needed
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Tue Apr 12 02:00:22 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Eitan Adler
>Release:
>Organization:
>Environment:
>Description:
I'm basing this PR entirely on the comment near the definition. I'm able to build ports with this patch. I think an exp-run would be useful "XXX Are these needed here? DESCR was set wrong for a few years
>How-To-Repeat:
>Fix:
Index: bsd.port.subdir.mk
===================================================================
RCS file: /home/ncvs/ports/Mk/bsd.port.subdir.mk,v
retrieving revision 1.77
diff -u -r1.77 bsd.port.subdir.mk
--- bsd.port.subdir.mk 20 Dec 2010 12:23:52 -0000 1.77
+++ bsd.port.subdir.mk 12 Apr 2011 01:38:34 -0000
@@ -50,11 +50,6 @@
MOVEDDIR?= ${PORTSDIR}
MOVEDFILE?= MOVED
-# XXX Are these needed here? DESCR was set wrong for a few years
-MASTERDIR?= ${.CURDIR}
-PKGDIR?= ${MASTERDIR}
-DESCR?= ${PKGDIR}/pkg-descr
-
.include "${PORTSDIR}/Mk/bsd.commands.mk"
.MAIN: all
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201104120159.p3C1xXcv061142>