Date: Tue, 14 May 2002 14:28:45 -0700 (PDT) From: Joerg Wunsch <joerg@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/isa fd.c Message-ID: <200205142128.g4ELSjP70451@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
joerg 2002/05/14 14:28:45 PDT
Modified files:
sys/isa fd.c
Log:
After some comments from bde, rewrite the loops to avoid turning the
previously used "micro-optimization" (count-down loop) into a
pessimization. Now the loops are written in the more natural count-up
form.
Also, while being there, i made the logic in out_fdc() similar to the
logic in in_fdc(). The old implementation was a bit bogus anyway
since it first tested the DIO bit and only afterwards the RQM bit.
However, according to the description of the i82077, the DIO bit is
only guaranteed to be valid once the RQM bit is set. Thus, the old
implementatoin would have had the chance to misbehave on a controller
that is implemented in accordance with the i82077 description (but is
not bug-for-bug compatible).
MFC after: 3 days
Revision Changes Path
1.233 +28 -42 src/sys/isa/fd.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200205142128.g4ELSjP70451>