Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 1 Aug 2007 22:20:31 GMT
From:      "Constantine A. Murenin" <cnst@FreeBSD.org>
To:        Perforce Change Reviews <perforce@FreeBSD.org>
Subject:   PERFORCE change 124494 for review
Message-ID:  <200708012220.l71MKVCa088474@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=124494

Change 124494 by cnst@dale on 2007/08/01 22:19:48

	better error handling, although lm_detach() always returns 0,
	so this doesn't matter that much

Affected files ...

.. //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78_isa.c#4 edit

Differences ...

==== //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78_isa.c#4 (text+ko) ====

@@ -1,4 +1,4 @@
-/*	$P4: //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78_isa.c#3 $	*/
+/*	$P4: //depot/projects/soc2007/cnst-sensors/sys.dev.lm/lm78_isa.c#4 $	*/
 /*	$FreeBSD$	*/
 /*	$OpenBSD: lm78_isa.c,v 1.2 2007/07/01 21:48:57 cnst Exp $	*/
 
@@ -232,10 +232,12 @@
 
 	/* Bus-independent detachment */
 	error = lm_detach(&sc->sc_lmsc);
+	if (error)
+		return (error);
 
 	bus_space_unmap(sc->sc_iot, sc->sc_ioh, 8);
 
-	return (error);
+	return (0);
 }
 
 u_int8_t



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200708012220.l71MKVCa088474>