Date: Wed, 15 Oct 2014 08:14:19 +0400 From: Gleb Smirnoff <glebius@FreeBSD.org> To: Ed Maste <emaste@freebsd.org> Cc: Olivier =?iso-8859-1?Q?Cochard-Labb=E9?= <olivier@cochard.me>, "George V. Neville-Neil" <gnn@freebsd.org>, svn-src-all <svn-src-all@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-head <svn-src-head@freebsd.org> Subject: Re: svn commit: r272906 - in head/sys: conf libkern netpfil/pf sys Message-ID: <20141015041418.GE73266@FreeBSD.org> In-Reply-To: <CAPyFy2CDSwLkTtPFj70tw2iuDam3rS4yFNri=pX0w7_58UYMoA@mail.gmail.com> References: <201410101926.s9AJQRY1049602@svn.freebsd.org> <CA%2Bq%2BTcpt0zEbgu_LndZb4dzh=xykHvppeykuiG6P9cTJgDGeWw@mail.gmail.com> <20141015030455.GC73266@FreeBSD.org> <CAPyFy2CDSwLkTtPFj70tw2iuDam3rS4yFNri=pX0w7_58UYMoA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 14, 2014 at 11:38:23PM -0400, Ed Maste wrote:
E> On 14 October 2014 23:04, Gleb Smirnoff <glebius@freebsd.org> wrote:
E> >
E> > Look at results at the end of email. Guess what -j and -m mean. I
E> > want either proving me doing the test wrong, or backing the change
E> > out ASAP.
E>
E> It looks like there is indeed an error in the test:
E>
E> > h = murmur3_aligned_32((uint32_t *)&key[i],
E> > sizeof(struct pf_state_key_cmp)/sizeof(uint32_t),
E>
E> murmur3's size argument is bytes, not uint32_ts, so the test is only
E> hashing the first 1/4 of the keys.
Thanks a lot, Ed. I rerun the tests. Results are fine. Distribution
is equal (plots attached).
Murmur is 9% +/- 1.5% faster. Sorry for noise.
x jenkins-time
+ murmur-time
+------------------------------------------------------------------------------+
| ++ x |
| ++ xx |
|+ +++ xx |
|+++++ + + xx x x x x x|
| |_A_| |_____M______A_____________| |
+------------------------------------------------------------------------------+
N Min Max Median Avg Stddev
x 12 8147243 8851519 8173132 8296753.8 235815.07
+ 15 7502767 7655925 7547376 7551089.5 39524.149
Difference at 95.0% confidence
-745664 +/- 127010
-8.98742% +/- 1.53084%
(Student's t, pooled s = 159194)
--
Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141015041418.GE73266>