Date: Tue, 4 Dec 2001 17:45:47 -0800 (PST) From: Luigi Rizzo <luigi@FreeBSD.org> To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/dev/fxp if_fxp.c src/sys/pci if_dc.c if_sis.c Message-ID: <200112050145.fB51jlt89284@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
luigi 2001/12/04 17:45:47 PST
Modified files: (Branch: RELENG_4)
sys/dev/fxp if_fxp.c
sys/pci if_dc.c if_sis.c
Log:
Make sure interrupts remain disabled once you reinitialize an interface
on which you have enabled polling.
This fixes the problem reported by a few people who enabled polling
from /etc/sysctl.conf .
Fixing the "fxp" driver was interesting: as a side effect of the
initialization, the chip turns interrupts on, and I was misled in
believing the opposite by the "Enable interrupts" comment in the code.
So i decided to make the code explicitly turn interrupts off even
in the "sis" driver which already had the correct code. You never know.
Note-to-self: never make assumptions on how things should work.
Note-to-others: did I test this case ? Yes, on a "sis" and "dc" board,
(the code for the latter was unintentionally lost during the final
code cleanup). I forgot to reproduce the actual problem on the "fxp",
because the interface was already initialized when i turned polling on.
Revision Changes Path
1.110.2.12 +9 -0 src/sys/dev/fxp/if_fxp.c
1.9.2.27 +10 -0 src/sys/pci/if_dc.c
1.13.4.12 +7 -1 src/sys/pci/if_sis.c
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200112050145.fB51jlt89284>