Date: Sat, 10 Sep 2005 23:01:38 -0700 From: "David O'Brien" <obrien@FreeBSD.org> To: Sam Leffler <sam@errno.com> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf files kern.pre.mk Message-ID: <20050911060138.GA83586@dragon.NUXI.org> In-Reply-To: <4323BB54.6060600@errno.com> References: <200509110338.j8B3cJwv098050@repoman.freebsd.org> <4323BB54.6060600@errno.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Sep 10, 2005 at 10:06:28PM -0700, Sam Leffler wrote: > David E. O'Brien wrote: > >obrien 2005-09-11 03:38:19 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/conf files kern.pre.mk > > Log: > > Don't pollute the entire kernel build with -I$S/contrib/dev/ath and > > -I$S/contrib/dev/ath/freebsd. "ATH_BUILDING_FROM_SOURCE" can be defined > > to > > globally get back -I$S/contrib/dev/ath. > > Thanks for explicitly ignoring my request for you NOT to do this. It's > really great how you do these drive-by commits that do nothing but f*ck > up people's development environment. > Sam I did my best to take your needs into account. I even asked you to propose a patch when you didn't like the ones I sent you - your response was "David, I have no time to waste on stuff like this." "-INCLUDES+= -I$S/contrib/dev/ath" should never have been in the public FreeBSD source tree as not a single file in /usr/src/sys needed it to compile. We don't commit Yahoo!'s, The Weather Channel, Interjet's or any other vendor-specific needs into the open source /usr/src. I think you're more than able to stick "ATH_BUILDING_FROM_SOURCE=yes" in the /etc/make.conf of the machines you build the ath(4) HAL on. I'm sorry you don't see that we shouldn't pollute the kernel build with tons of -I's. It was getting out of hand that every one felt they could add yet another global -I with every new code import rather than edit their code to build in our tree correctly. -- -- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050911060138.GA83586>