Date: Tue, 01 Dec 2015 08:31:22 -0800 From: Ravi Pokala <rpokala@mac.com> To: Hajimu UMEMOTO <ume@FreeBSD.org>, Ravi Pokala <rpokala@mac.com> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r291592 - head/usr.bin/netstat Message-ID: <70ADB754-1404-4666-864C-D8E051F59409@panasas.com> In-Reply-To: <ygebnaai18n.wl-ume@FreeBSD.org> References: <201512011604.tB1G4pHa000698@repo.freebsd.org> <319A5F79-53CD-40A1-9076-CF3EF33858A9@panasas.com> <ygebnaai18n.wl-ume@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----Original Message-----
From: Hajimu UMEMOTO <ume@FreeBSD.org>
Date: 2015-12-01, Tuesday at 08:26
To: Ravi Pokala <rpokala@mac.com>
Cc: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>
Subject: Re: svn commit: r291592 - head/usr.bin/netstat
>Hi,
>
>>>>>> On Tue, 01 Dec 2015 08:13:41 -0800
>>>>>> Ravi Pokala <rpokala@mac.com> said:
>
>rpokala> The value returned by p_sockaddr("destination", ...) is saved to "protrusion", but it is never used before it is overwritten by the value returned by p_sockaddr("gateway", ...). That doesn't seem right.
>
>The protrusion is given to the argument of next p_sockaddr() call.
<facepalm>
How did I miss that? Looks like it's time for new glasses. :-/
-Ravi
>Sincerely,
>
>--
>Hajimu UMEMOTO
>ume@mahoroba.org ume@FreeBSD.org
>http://www.mahoroba.org/~ume/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?70ADB754-1404-4666-864C-D8E051F59409>