Date: Mon, 31 Oct 2016 06:19:51 +0800 From: Li-Wen Hsu <lwhsu@FreeBSD.org> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r308107 - in head/sys/modules/bhnd: . bcma bcma_bhndb bhndb bhndb_pci cores/bhnd_pci cores/bhnd_pci_hostb cores/bhnd_pcib siba siba_bhndb Message-ID: <20161030221951.GA86782@FreeBSD.cs.nctu.edu.tw> In-Reply-To: <4862480.RxOcpDe54A@ralph.baldwin.cx> References: <201610301556.u9UFuhAi009407@repo.freebsd.org> <4862480.RxOcpDe54A@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
--liOOAslEiF7prFVr Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Oct 30, 2016 at 15:05:49 -0700, John Baldwin wrote: > On Sunday, October 30, 2016 03:56:43 PM Li-Wen Hsu wrote: > > Author: lwhsu (ports committer) > > Date: Sun Oct 30 15:56:42 2016 > > New Revision: 308107 > > URL: https://svnweb.freebsd.org/changeset/base/308107 > >=20 > > Log: > > - Fix `make` in sys/modules/bhnd > > =20 > > Approved by: landonf > > Differential Revision: https://reviews.freebsd.org/D7774 >=20 > This is wrong. bhnd_debug.h should not have '#include opt_global.h'. It= is > included implicitly during kernel builds via '-include' in CFLAGS. It is > always incorrect to include it explicitly in source. This should be > reverted and bhnd_debug.h should be fixed instead. Got it, reverted in r308115. --=20 Li-Wen Hsu <lwhsu@FreeBSD.org> https://lwhsu.org --liOOAslEiF7prFVr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJ8BAEBCgBmBQJYFnIGXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQxMDdENTNGNjUyMTUzMzVCNzA5NDNGODQ2 NzI3RTc3Qzg4NjJCNjU2AAoJEGcn53yIYrZWvRIP/3HbcDartsocVKvlsoaG5E1W BG7yyDvo2NsmxgE0zq7ismBqmFYQDIMfKaD5Fuxsma3yVuSrUUlIxjp0t8igaISw Q2k0AS4fkazLhAQERHIo3EpjmBgIapI9q6Bm34gXL4zDARuWN+F9lifs5Cf+Q3lf UcdGshhnl+xsRpYjQ00mz+VBeNYWwBIoLdy34aAGVu/SUuXZkKIskhHWIeEQi7Cw /w+BRefEM3eyR0SybkbXBeDJQir9C584cFOPVb17bmUnD+U6HiVrdQMYvhzbkJbT YVbE2CgzqGcVsv7LqV1skxV6iO8mzQ9K9i4z76xgHGaXwMRrizD4pCruzu/UJ10V b/fKpmzMia7Pshs+HGw7wpF2CUFudVpibLZGCExflXffmDB4nnC/tU6K/t4Dl3GC 4F1GwEwekjBdtOsxNfeU0/K0UAfcBU7K/VMiQ19Ajmpn79hYUAgm0AIH23Ye9BHu aEEzKC3KNSu4Jgu9zjSN0UpxPzFDNGVwrEMM8JtYucBW0qvfRxEHlnWCRGR6axHp gxWizyCF1Gn3bP94sPGz261kNgOmWkS3vrEIAvNHImXOXwVil1J3n38OCRF448Ft ta92OXakOY9Yna6vSwr/8+G/LAn0IvLZ+t567RQjb5DcmezuFC7sJV7qwPge8JPB i1jvUH53y6SumMey2G8g =+gYj -----END PGP SIGNATURE----- --liOOAslEiF7prFVr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20161030221951.GA86782>