Date: 21 Jun 2002 18:07:50 -0400 From: Joe Marcus Clarke <marcus@marcuscom.com> To: Alexander Kabaev <ak03@gte.com> Cc: freebsd-current@FreeBSD.ORG, sean@chittenden.org Subject: Re: The -current state of mozilla affairs Message-ID: <1024697270.58209.24.camel@shumai.marcuscom.com> In-Reply-To: <20020621155921.79fc4c91.ak03@gte.com> References: <3CFC588A.9070903@sbcglobal.net> <20020604134655.B62465@xor.obsecurity.org> <20020619183056.K31745@ninja1.internal> <1024539159.44782.21.camel@shumai.marcuscom.com> <20020619232135.D37593@ninja1.internal> <20020620102527.C55653@dragon.nuxi.com> <1024597364.329.26.camel@gyros.marcuscom.com> <20020621155921.79fc4c91.ak03@gte.com>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Fri, 2002-06-21 at 15:59, Alexander Kabaev wrote: > Why not to use GCC version itself to distinguish between > thunked/non-thunked vtable implementations? The full comments in the header file illustrate why the Mozilla teamed keyed off of the internal compiler revision. Basically, almost all ports-based compilers were thunked, and there was a short period of time in early 4.0 when a thunked system GCC was in the tree. Note, we are using the FreeBSD compiler revision, and not __FreeBSD_version in this header. Joe > > > > Please add a comment why you chose these __FreeBSD_cc_version > > > values. What is special about 500003? 500003 is 5.0-CURRENT after > > > buf/bio changes, *years* ago. Perhaps you wanted another value from > > > http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/freebsd-versions.html > > > > Fear not. I'm modifying the patch. Proper documentation will be > > included. > > > > Joe > -- > Alexander Kabaev > [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.7 (FreeBSD) iD8DBQA9E6O2b2iPiv4Uz4cRAlPOAKClYSZblefUJMygjce4i2eBZxl67wCfThuN PYL5hWaMjpQ9AY164NJxFBY= =PC4O -----END PGP SIGNATURE-----help
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1024697270.58209.24.camel>