Date: Sat, 8 Dec 2007 05:33:04 GMT From: Weongyo Jeong <weongyo.jeong@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: kern/118493: [ndis] a trivial fix when ndis sets `ndis_resource_list' structure. Message-ID: <200712080533.lB85X4hI019925@www.freebsd.org> Resent-Message-ID: <200712080540.lB85e1jp069593@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 118493
>Category: kern
>Synopsis: [ndis] a trivial fix when ndis sets `ndis_resource_list' structure.
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Sat Dec 08 05:40:01 UTC 2007
>Closed-Date:
>Last-Modified:
>Originator: Weongyo Jeong
>Release: FreeBSD-CURRENT
>Organization:
CDNetworks
>Environment:
>Description:
When NDIS try to set `ndis_resource_list' structure in
ndis_convert_res() function, handling SYS_RES_MEMORY is weird because it sets
prd->u.cprd_port.cprd_start.np_quad
not
prd->u.cprd_mem.cprd_start.np_quad
This difference does not make any problems but made me confusing to read codes.
>How-To-Repeat:
>Fix:
Index: kern_ndis.c
===================================================================
RCS file: /data/cvs/src/sys/compat/ndis/kern_ndis.c,v
retrieving revision 1.96
diff -u -r1.96 kern_ndis.c
--- kern_ndis.c 10 Jun 2007 04:40:13 -0000 1.96
+++ kern_ndis.c 8 Dec 2007 05:05:43 -0000
@@ -644,9 +644,9 @@
CM_RESOURCE_MEMORY_READ_WRITE;
prd->cprd_sharedisp =
CmResourceShareDeviceExclusive;
- prd->u.cprd_port.cprd_start.np_quad =
+ prd->u.cprd_mem.cprd_start.np_quad =
brle->start;
- prd->u.cprd_port.cprd_len = brle->count;
+ prd->u.cprd_mem.cprd_len = brle->count;
break;
case SYS_RES_IRQ:
prd->cprd_type = CmResourceTypeInterrupt;
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200712080533.lB85X4hI019925>