Date: Thu, 28 Aug 2003 00:39:59 +0200 From: Thomas Quinot <thomas@FreeBSD.ORG> To: Matt <matt@xtaz.co.uk> Cc: freebsd-current@FreeBSD.ORG Subject: Re: HEADS UP! ATAng committed Message-ID: <20030827223959.GB64218@melusine.cuivre.fr.eu.org> In-Reply-To: <hk63ml.k5h2g3@webmail.xtaz.co.uk> References: <200308241328.h7ODSjwC067165@spider.deepcore.dk> <hk4n9l.hl0s3y@webmail.xtaz.co.uk> <20030825014824.GA6311@melusine.cuivre.fr.eu.org> <hk63ml.k5h2g3@webmail.xtaz.co.uk>
next in thread | previous in thread | raw e-mail | index | archive | help
Le 2003-08-25, Matt écrivait :
> Fatal trap 12: page fault while in kernel mode
> fault virtual address = 0x0
> fault code = supervisor write, page not present
> instruction pointer = 0x8:0xc015e59e
> stack pointer = 0x10:0xd717bac0
> frame pointer = 0x10:0xd717bacc
> code segment = base 0x0, limit 0xfffff, type 0x1b
> = DPL 0, pres 1, def32 1, gran 1
> processor eflags = interrupt enabled, resume, IOPL = 0
> current process = 18 (swi3: cambio)
> kernel: type 12 trap, code=0
> Stopped at free_hcb+0x2e: movl %eax,0(%edx)
OK, trivial one. Thanks to all who contributed feedback on this issue.
Thomas.
Index: atapi-cam.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/ata/atapi-cam.c,v
retrieving revision 1.20
diff -u -r1.20 atapi-cam.c
--- atapi-cam.c 24 Aug 2003 17:48:05 -0000 1.20
+++ atapi-cam.c 27 Aug 2003 22:35:56 -0000
@@ -465,9 +465,10 @@
if ((ccb_h->flags & CAM_DIR_MASK) == CAM_DIR_IN && (len & 1)) {
/* ATA always transfers an even number of bytes */
if (!(buf = hcb->dxfer_alloc = malloc(++len, M_ATACAM,
- M_NOWAIT | M_ZERO)))
+ M_NOWAIT | M_ZERO))) {
printf("cannot allocate ATAPI/CAM buffer\n");
goto action_oom;
+ }
}
request->device = dev;
request->driver = hcb;
--
Thomas.Quinot@Cuivre.FR.EU.ORG
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030827223959.GB64218>