Date: Wed, 5 Jan 2022 20:13:03 GMT From: Alexander Motin <mav@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: ce881170088c - main - atkbd: Disable periodic polling by default. Message-ID: <202201052013.205KD3HJ024209@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by mav: URL: https://cgit.FreeBSD.org/src/commit/?id=ce881170088c4c98c036fe561f8ee8413c2e2585 commit ce881170088c4c98c036fe561f8ee8413c2e2585 Author: Alexander Motin <mav@FreeBSD.org> AuthorDate: 2022-01-05 20:00:36 +0000 Commit: Alexander Motin <mav@FreeBSD.org> CommitDate: 2022-01-05 20:12:58 +0000 atkbd: Disable periodic polling by default. It is one of the few remaining Giant-locked callouts. It would be good to remove it, not mentioning that polling itself is not good. If this cause keyboard/mouse freezes on some hardware, please set loader tunable hw.atkbd.hz=1 as workaround and report the issue. Submitted by: imp, jhb --- sys/dev/atkbdc/atkbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/atkbdc/atkbd.c b/sys/dev/atkbdc/atkbd.c index cee1207df973..e87e5591150c 100644 --- a/sys/dev/atkbdc/atkbd.c +++ b/sys/dev/atkbdc/atkbd.c @@ -77,7 +77,7 @@ typedef struct atkbd_state { static SYSCTL_NODE(_hw, OID_AUTO, atkbd, CTLFLAG_RD | CTLFLAG_MPSAFE, 0, "AT keyboard"); -static int atkbdhz = 1; +static int atkbdhz = 0; SYSCTL_INT(_hw_atkbd, OID_AUTO, hz, CTLFLAG_RWTUN, &atkbdhz, 0, "Polling frequency (in hz)");
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202201052013.205KD3HJ024209>