Date: Wed, 10 Jun 2009 10:15:57 +0400 (MSD) From: Dmitry Morozovsky <marck@rinet.ru> To: Kip Macy <kmacy@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r193878 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs Message-ID: <alpine.BSF.2.00.0906101013480.49870@woozle.rinet.ru> In-Reply-To: <200906100121.n5A1LWVO089719@svn.freebsd.org> References: <200906100121.n5A1LWVO089719@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kip, On Wed, 10 Jun 2009, Kip Macy wrote: KM> Author: kmacy KM> Date: Wed Jun 10 01:21:32 2009 KM> New Revision: 193878 KM> URL: http://svn.freebsd.org/changeset/base/193878 KM> KM> Log: KM> As far as I can tell systems that have less than 4GB are more often hurt KM> by prefetched than helped. On i386 systems and systems with less than 4GB, KM> prefetch is now disabled by default. I've added a prefetch enable tunable, to KM> enable prefetching for those systems. The prefetch disable tunable will continue KM> to unconditionally disable prefetching. KM> [snip] KM> +extern int zfs_prefetch_disable; KM> +extern int zfs_prefetch_enable; [snip] Before the interface is not settled in stone, don't you think simple bool zfs_prefetch tunable (defauled to what looks more reasonable to partucilar arch/memsize) is more clean and straightforward? -- Sincerely, D.Marck [DM5020, MCK-RIPE, DM3-RIPN] [ FreeBSD committer: marck@FreeBSD.org ] ------------------------------------------------------------------------ *** Dmitry Morozovsky --- D.Marck --- Wild Woozle --- marck@rinet.ru *** ------------------------------------------------------------------------
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?alpine.BSF.2.00.0906101013480.49870>