Date: Sat, 21 Aug 1999 00:50:52 -0700 (PDT) From: "Brian F. Feldman" <green@FreeBSD.org> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_physio.c Message-ID: <Pine.BSF.4.10.9908210046530.55604-100000@freefall.freebsd.org> In-Reply-To: <11658.935221411@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 21 Aug 1999, Poul-Henning Kamp wrote:
> >+ bp->b_blkno = blockno;
> >+ if (bp->b_blkno != blockno) {
> > ^- How can this comparison ever fail?
>
> They're different sizes.
But you set bp->b_blkno to blockno, then compare whether or not they're
equal. I'm pretty sure that's not right.
>
> --
> Poul-Henning Kamp FreeBSD coreteam member
> phk@FreeBSD.ORG "Real hackers run -current on their laptop."
> FreeBSD -- It will take a long time before progress goes too far!
>
>
--
Brian Fundakowski Feldman / "Any sufficiently advanced bug is \
green@FreeBSD.org | indistinguishable from a feature." |
FreeBSD: The Power to Serve! \ -- Rich Kulawiec /
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.10.9908210046530.55604-100000>