Date: Fri, 6 Sep 1996 10:39:19 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@GndRsh.aac.dev.com> To: se@zpr.uni-koeln.de (Stefan Esser) Cc: rgrimes@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/pci pcisupport.c Message-ID: <199609061739.KAA13211@GndRsh.aac.dev.com> In-Reply-To: <199609061708.TAA16633@x14.mi.uni-koeln.de> from Stefan Esser at "Sep 6, 96 07:08:57 pm"
next in thread | previous in thread | raw e-mail | index | archive | help
> Rodney W. Grimes writes: > > > rgrimes 96/09/06 02:17:09 > > > > > Looking at this file and all the #if defined (I686_CPU) cruft and the > > ordering of chipsets makes me want a cleaner approach. Also you have > > to be _VERY_ carefull on what you exclude from certain CPU classes, > > especially with devices other than HOST/PCI bridges (ie, a PCI/anything > > bridge _can_ be used with _ANY_ cpu class. > > Well, I did make sure I got that right, > but the #if defined (Ix86_CPU) will all > go away again, since it was an outright > silly idea ... Not really a silly idea, just the implementation of how it is makes it kinda messy, not that I have a better way to do it :-(. I'll think on it for a while... > See my reply to Michael Smith, who rightly > complained about his, too ... Yea.. now that is a much better reason for the evil #ifdef's to go away... > > Stephan, do you really want to be doing that in here?? > > No, I really don't, anymore ... Okay. This simplifies my next round of patches a lot, I'll wait until after this is cleaned up. > I'll back those changes out, if you don't > beat me on it (which shouldn't be too hard > given your much better connectivity to > Freefall :) If you don't get to it today, I'll probably back them out tomarrow some time. Oh, and are you doing any more major work in there? I want to do some reorg and major comment cleanup (I'll pass a diff by the list first). Then I will be adding full register dump support for 439HX, 440FX and associated functions/chips (got to figure out how to get the USB function of the 82371SB turned on first though :-)). -- Rod Grimes rgrimes@gndrsh.aac.dev.com Accurate Automation Company Reliable computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199609061739.KAA13211>