Date: Mon, 27 Apr 2020 00:50:14 +0000 From: bugzilla-noreply@freebsd.org To: python@FreeBSD.org Subject: [Bug 241565] [NEW PORT] textproc/py-iso3166: Standalone ISO 3166-1 country definitions Message-ID: <bug-241565-21822-R9hfkMcMNN@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-241565-21822@https.bugs.freebsd.org/bugzilla/> References: <bug-241565-21822@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D241565 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-patch --- Comment #9 from Kubilay Kocak <koobs@FreeBSD.org> --- Minor review items: 1) Match COMMENT to setup.py:description (modulo portlint compliance) 2) Package has tests shipped with it. Add TEST_DEPENDS and (do-)test target= for better QA accordingly. Ask upstream to package tox.ini and declare tests_require=3Dpytest in setup.py so it makes figuring out how to run tests quicker/easier for downstream consumers (packages *and* users). The above changes don't require maintainer approval (ports (python) complia= nce) @Kyle This needs QA confirmation (including maketest: after (2)) to progres= s. To assist with the test target, for pytest, the usual caonical and deterministic invocation command is:=20 do-test: @cd ${WRKSRC} && ${PYTHON_CMD} -m pytest -v -rs -o addopts=3D --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-241565-21822-R9hfkMcMNN>