Date: Tue, 9 Mar 2010 20:49:31 -0800 From: "David O'Brien" <obrien@FreeBSD.org> To: "M. Warner Losh" <imp@bsdimp.com> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, dougb@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r204824 - head/sys/conf Message-ID: <20100310044931.GD96059@dragon.NUXI.org> In-Reply-To: <20100309.193512.775474398290078267.imp@bsdimp.com> References: <4B945CAC.9020706@FreeBSD.org> <20100310015551.GA12405@dragon.NUXI.org> <4B97030A.1040704@FreeBSD.org> <20100309.193512.775474398290078267.imp@bsdimp.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 09, 2010 at 07:35:12PM -0700, M. Warner Losh wrote:
>
> I'd recommend something similar to the following change:
> Index: newvers.sh
..
> +S=sys
..
> -*/sys/*)
> +*/$S/*)
> SRCDIR=${d##*obj}
> if [ -n "$MACHINE" ]; then
> SRCDIR=${SRCDIR##/$MACHINE}
> fi
> - SRCDIR=${SRCDIR%%/sys/*}
> + SRCDIR=${SRCDIR%%/$S/*}
Why not make it simpler as my patch did? Do you not trust that
newvers.sh (e.g. "$0") is within the kernel directory?
> which would allow people that move sys to somewhere else to change one
> line and still have everything work. They are going to have to make
> changes anyway to support that, since it isn't supported by FreeBSD
> out of the box.
Eh? 'svn co svn://svn.freebsd.org/base/head/sys syshead' works as-is.
Using "$0" requires no one to have to change a single line.
--
-- David (obrien@FreeBSD.org)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100310044931.GD96059>