Date: Thu, 1 Jun 2017 11:27:18 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: "Simon J. Gerraty" <sjg@juniper.net>, Marcel Moolenaar <marcel@FreeBSD.org>, src-committers <src-committers@FreeBSD.org>, svn-src-all@FreeBSD.org, Brooks Davis <brooks@FreeBSD.org>, svn-src-head@FreeBSD.org, Ngie Cooper <ngie@FreeBSD.org> Subject: Re: svn commit: r319295 - head/usr.bin/mkimg/tests Message-ID: <EB38926C-C27C-4404-A1C4-69BC8525A00C@gmail.com> In-Reply-To: <20170601171642.GA601@FreeBSD.org> References: <201705310801.v4V81CjO004032@repo.freebsd.org> <20170601050339.GA48398@spindle.one-eyed-alien.net> <7FC9CB7D-CF96-4ACA-A38C-E82836127BA4@gmail.com> <84744.1496336318@kaos.jnpr.net> <20170601171642.GA601@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_70298DD0-5C10-4996-8206-E9E727E1224C Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jun 1, 2017, at 10:16, Alexey Dokuchaev <danfe@freebsd.org> wrote: >=20 > On Thu, Jun 01, 2017 at 09:58:38AM -0700, Simon J. Gerraty wrote: >> One option would be to store a sha256 hash of the result. >> If the image generated by the test hashes to the correct value - you >> pass. >=20 > That should be preferred. Storing binary blobs in VCS is bad = practice. >=20 >> Of course if the test fails, you are completely in the dark as to >> how/why. >=20 > Not really: you checkout previous version (which produces correct = hash) > and store generated image for later inspection and diffing. >=20 >> Is storing img-1x1-512-mbr.vmdk.gz any more palatable? >=20 > This is barely acceptable, but only if image was zerofied/sparsed = prior > to compression. Also, the image should be of the minimal (sufficient) > working size. I vote for not checking in the SHAs. If something fails (as = someone else mentioned on the lists), it=E2=80=99s really hard to debug = why it failed. I think marcel@=E2=80=99s proposal for hexdump -C text dumps are = the best way to handle this. Thanks, -Ngie --Apple-Mail=_70298DD0-5C10-4996-8206-E9E727E1224C Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJZMFyHAAoJEPWDqSZpMIYVOWkP/RiWtIzJXiUBzKzgBvUwbTT+ JFLyYY1F+YqKUJsJLInOzF4rKiO7nVVb0edvr10EYFjkfkttItxwnYZAzrjdbHrc nipBzXmuOgDf0zUy8MHOucvIa+IdQ7fgdcX42dB9r3pb1E7ZTwxd3ju++eW8CWZc u0VlxX5L9/hgA5Q8rh2yS+V1PQt/mNS0iO2cM39JJtr8nhJ5cz6KAPIn0+7bErLq CA4xydgjEsBSZb77oAymE+MpYKsoa2j1HW+qaJUSIfV+dNuaUmM91w4i2E0WjEeV iQ/AierBY0QBtUgjBQZUcMgLp3wOdFQG94HlUnQqs86ejrmFCRj44YGBDH2lubpQ axxu6U0y6ja4R7XQxu1gKZaIrOMkbB2pCHFL0XUV3Iv3uSAt8fam75ZhA8X+xvvZ PGag0NDoDO+v0LS2FazyZpgPuvdSnbiFDN7w3eCH6SOf/o0+/gN4LmD2MB2m9bRc b97ra7RHmEbg1syJTxZVolQFqCNx3j3AX7FIdNKOTXNy8Vgr0Z4AxwjaGATlXKM8 4htHWFfEKzJsa31AID3+PnRacqrlDkruxVhofNMDseoJduwrC3P+G2PP4xXNx8Hy E5XZjfRJZEJu9mJJODffx5Jb7RHyBhSh4g3yh2KTbjEmD/4lHgM3t6tHczP3x68d jLLwfqSS/hufMCaecIWt =YJ/f -----END PGP SIGNATURE----- --Apple-Mail=_70298DD0-5C10-4996-8206-E9E727E1224C--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?EB38926C-C27C-4404-A1C4-69BC8525A00C>