Date: Wed, 21 Sep 2016 09:26:09 +0200 From: Edward Tomasz Napierala <trasz@freebsd.org> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: Alan Somers <asomers@freebsd.org>, Alexander Motin <mav@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r305988 - in head/sys: geom sys Message-ID: <20160921072609.GB25303@brick> In-Reply-To: <03DFBBFF-FA98-48CB-8180-B03B37538301@gmail.com> References: <201609191746.u8JHkFKI071354@repo.freebsd.org> <CAOtMX2gSNewQK308fToOV9zTZD=icStA2=H9mqD4tjpv3pyY%2BA@mail.gmail.com> <a8de869c-4947-9d96-21bc-2c5c722ea798@FreeBSD.org> <CAOtMX2h=aX0voEKdXFpgiRN6Hgk-i_kxGRb30Q=VG25BNB_X8g@mail.gmail.com> <03DFBBFF-FA98-48CB-8180-B03B37538301@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 0920T0934, Ngie Cooper (yaneurabeya) wrote: > > > On Sep 20, 2016, at 09:28, Alan Somers <asomers@freebsd.org> wrote: > > > > On Tue, Sep 20, 2016 at 10:23 AM, Alexander Motin <mav@freebsd.org> wrote: > >> On 20.09.2016 09:20, Alan Somers wrote: > >>> On Mon, Sep 19, 2016 at 11:46 AM, Edward Tomasz Napierala > >>> <trasz@freebsd.org> wrote: > >>>> Author: trasz > >>>> Date: Mon Sep 19 17:46:15 2016 > >>>> New Revision: 305988 > >>>> URL: https://svnweb.freebsd.org/changeset/base/305988 > >>>> > >>>> Log: > >>>> Remove unused bio_taskqueue(). > >>>> > >>>> MFC after: 1 month > >>>> > >>>> Modified: > >>>> head/sys/geom/geom_io.c > >>>> head/sys/sys/bio.h > >>>> > >>> > >>> This is a KBI change, so you should bump __FreeBSD_version. You > >>> probably shouldn't MFC it, either. > >> > >> The last/only consumer of this KPI I know gone with FreeBSD 9 and old > >> ATA stack. Do you know any other? > > > > Nothing in-tree. But it's publicly visible, so we have no way of > > knowing who might be using it out-of-tree. > > I’d have to check, but this might impact us (Isilon). We don’t use the __FreeBSD_version #ifdefs though in our code, so it’s fine from my perspective to leave things alone. > > That being said, are you sure that port klds (e.g. open-vm-tools*) aren’t impacted by this change? Did it go through a ports -exp run? I'm not sure if it's worth it. If something comes up, I'll fix it.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160921072609.GB25303>