Date: Sun, 21 Jun 2009 18:23:23 +0200 From: Gary Jennejohn <gary.jennejohn@freenet.de> To: Roman Divacky <rdivacky@freebsd.org> Cc: current@freebsd.org Subject: Re: [PATCH]: if (cond); foo() in firewire Message-ID: <20090621182323.5eb46969@ernst.jennejohn.org> In-Reply-To: <20090621082022.GA88526@freebsd.org> References: <20090621082022.GA88526@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 21 Jun 2009 10:20:22 +0200 Roman Divacky <rdivacky@freebsd.org> wrote: > hi > > is this patch correct? may I commit it? > > Index: ../../../dev/firewire/fwdev.c > =================================================================== > --- ../../../dev/firewire/fwdev.c (revision 194573) > +++ ../../../dev/firewire/fwdev.c (working copy) > @@ -443,7 +443,7 @@ > xfer->send.pay_len = uio->uio_resid; > if (uio->uio_resid > 0) { > if ((err = uiomove((caddr_t)&xfer->send.payload[0], > - uio->uio_resid, uio))); > + uio->uio_resid, uio))) > goto out; > } > > > another bug found by the "useless warnings in clang" ;) > Certainly looks like it should be corrected. I'd say go ahead and commit it in my guise as a former src-committer :) --- Gary Jennejohn
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090621182323.5eb46969>