Date: Mon, 01 Apr 2013 11:44:50 -0400 From: Karim Fodil-Lemelin <fodillemlinkarim@gmail.com> To: freebsd-net@freebsd.org Subject: Re: igb and ALTQ in 9.1-rc3 Message-ID: <5159AB72.1050202@gmail.com> In-Reply-To: <CAFOYbcn3HpRaaoSPWF5OL6QJCec-Zb2%2BNySqjgqyOXHRaXD26Q@mail.gmail.com> References: <1355177348.71087.YahooMailClassic@web121601.mail.ne1.yahoo.com> <50C6656E.3020601@gmail.com> <CAFOYbc=79HwkHm6PAyRba%2Bue_7Xq0dUJvLk48RwqUN0Oz6%2BVFw@mail.gmail.com> <20121211075853.GU48639@FreeBSD.org> <CAFOYbc=Yh3WiUDstjSm-AUz4WMF9VteiydcEb5opnJ_gT4F7ag@mail.gmail.com> <CAKOb=Yb7NMm26=u%2B-0ywMk543WdXc5uiO2omY4=TXpRxPrOWHg@mail.gmail.com> <CAFOYbcn3HpRaaoSPWF5OL6QJCec-Zb2%2BNySqjgqyOXHRaXD26Q@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi Jack, I think this would help M. Rogers case as we have done something similar here to circumvent the issue and it seems to work well. I would also add that when using ALTQ we found it much more stable to set the number of queues to 1: static int igb_num_queues = 1; Our approach consisted in keeping igb_start() defined and using igb_mq_start_locked() inside it instead of igb_start_locked(). Regards, Karim. On 28/03/2013 7:16 PM, Jack Vogel wrote: > Have been kept fairly busy with other matters, one thing I could do short > term is > change the defines in igb the way I did in the em driver so you could still > define > the older if_start entry. Right now those are based on OS version and so > you will > automatically get if_transmit, but I could change it to be IGB_LEGACY_TX or > so, > and that could be defined in the Makefile. > > Would this help? > > Jack > > > On Thu, Mar 28, 2013 at 2:31 PM, Nick Rogers <ncrogers@gmail.com> wrote: > >> On Tue, Dec 11, 2012 at 1:09 AM, Jack Vogel <jfvogel@gmail.com> wrote: >>> On Mon, Dec 10, 2012 at 11:58 PM, Gleb Smirnoff <glebius@freebsd.org> >> wrote: >>>> On Mon, Dec 10, 2012 at 03:31:19PM -0800, Jack Vogel wrote: >>>> J> UH, maybe asking the owner of the driver would help :) >>>> J> >>>> J> ... and no, I've never been aware of doing anything to stop >> supporting >>>> altq >>>> J> so you wouldn't see any commits. If there's something in the altq >> code >>>> or >>>> J> support (which I have nothing to do with) that caused this no-one >>>> informed >>>> J> me. >>>> >>>> Switching from if_start to if_transmit effectively disables ALTQ >> support. >>>> AFAIR, there is some magic implemented in other drivers that makes them >>>> modern (that means using if_transmit), but still capable to switch to >>>> queueing >>>> mode if SIOCADDALTQ was casted upon them. >>>> >>>> >>> Oh, hmmm, I'll look into the matter after my vacation. >>> >>> Jack >> Has there been any progress on resolving this issue? I recently ran >> into this problem upgrading my servers from 8.3 to 9.1-RELEASE and am >> wondering what the latest recommendation is. I've used ALTQ and igb >> successfully for years and it is unfortunate it no longer works. >> Appreciate any advice. >> >>> _______________________________________________ >>> freebsd-net@freebsd.org mailing list >>> http://lists.freebsd.org/mailman/listinfo/freebsd-net >>> To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org" > _______________________________________________ > freebsd-net@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-net > To unsubscribe, send any mail to "freebsd-net-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5159AB72.1050202>