Date: Mon, 26 Feb 2001 04:13:37 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: Jake Burkholder <jburkholder0829@home.com> Cc: Peter Wemm <peter@netplex.com.au>, Jake Burkholder <jake@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 db_trace.c exception.s machdep.c trap.c src/sys/i386/include asnames.h Message-ID: <Pine.BSF.4.21.0102260354130.1090-100000@besplex.bde.org> In-Reply-To: <20010225151234.1ADCFBACB@cr66388-a.rchrd1.on.wave.home.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 25 Feb 2001, Jake Burkholder wrote: > > On Sat, 24 Feb 2001, Peter Wemm wrote: > > > > > Bruce Evans wrote: > > > Well, given that we have two, "Xsyscall" was wrong as it implies that it > > > was the "normal" one (it is not). Would you rather that Xint0x80syscall > > > be renamed to Xsyscall instead? > > > > Yes. > > > > Ok. > > My concern is that Xsyscall and syscall are very similar. I might > confuse them at 4 am. What about changing the X to something clearer > like idt_ ? I prefer short names, and wouldn't confuse them. >> [how mcount works in X*syscall] > > How does this work for traps then? They all jump to the common > alltraps label. It doesn't really work :-]. The entry point gets forgotten, much the same as for Xlcall_sycall. "MCOUNT_LABEL(btrap)" combined with not using complete labels for the entry points of the trap handlers has the (mostly unintentional) side effect of combining the tick counts for all the trap handler stubs. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0102260354130.1090-100000>