Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Jul 2004 22:24:57 -0400
From:      Garance A Drosihn <drosih@rpi.edu>
To:        Marcel Moolenaar <marcel@xcllnt.net>
Cc:        current@freebsd.org
Subject:   Re: CVSUP and 5.2.1 RELEASE
Message-ID:  <p0611041abd1a49199d83@[128.113.24.47]>
In-Reply-To: <20040713232214.GA9507@dhcp50.pn.xcllnt.net>
References:  <26075.1089753893@critter.freebsd.dk> <p06110415bd1a0dedbf1c@[128.113.24.47]> <20040713232214.GA9507@dhcp50.pn.xcllnt.net>

next in thread | previous in thread | raw e-mail | index | archive | help
At 4:22 PM -0700 7/13/04, Marcel Moolenaar wrote:
>On Tue, Jul 13, 2004 at 06:23:38PM -0400, Garance A Drosihn wrote:
>>
>>  a) how about if we print a warning and exit if DESTDIR is
>>     not defined?  Are there "important" uses of `make world'
>>     which do not use DESTDIR?
>
>My thoughts exactly. See attached patch.

Actually, the target should end with some kind of failure, in
case someone has a script that does:
      make world && do-next-thing

if we change `make world' to do nothing, then sequences like
this should error-out right away.  So I think it should have
a "false" command after all the @echo's...

-- 
Garance Alistair Drosehn            =   gad@gilead.netel.rpi.edu
Senior Systems Programmer           or  gad@freebsd.org
Rensselaer Polytechnic Institute    or  drosih@rpi.edu



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?p0611041abd1a49199d83>