Date: Wed, 16 Mar 2016 21:30:39 -0700 From: "Simon J. Gerraty" <sjg@juniper.net> To: Bryan Drewery <bdrewery@freebsd.org> Cc: NGie Cooper <yaneurabeya@gmail.com>, <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-head@freebsd.org>, <sjg@juniper.net> Subject: Re: svn commit: r296970 - head/lib/libxo/tests Message-ID: <86203.1458189039@kaos.jnpr.net> In-Reply-To: <56EA2E93.2020406@FreeBSD.org> References: <201603170037.u2H0b4Rb082849@repo.freebsd.org> <984878F0-9CE9-442D-8F7F-40C5365052AA@gmail.com> <85789.1458187497@kaos.jnpr.net> <56EA2E93.2020406@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Bryan Drewery <bdrewery@freebsd.org> wrote:
> Btw I recently hooked up MK_TESTS to DIRDEPS_BUILD and added them all
> (at the time) to targets/.
Hmm how did you do that?
In our build local.dirdeps.mk checks each DEP_RELDIR to see if there is
a tests/Makefile.depend.host below it, and if so adds it to the
dependency graph - but not to the dependencies of DEP_RELDIR - which
could introduced circular dependencies.
[It also has to check if ${DEP_RELDIR}/tests is listed as broken for the
current host os - not all tests can run on all build hosts]
Thus we build all the tests (and only the tests) relevant to what we are
building.
And since when building tests for "host" we run them immediately, if any
fail the build fails.
Hooking all the tests into a tests target is useful too of course.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86203.1458189039>