Date: Tue, 21 Mar 2017 07:50:32 +0100 From: Antoine Brodin <antoine@freebsd.org> To: Gleb Smirnoff <glebius@freebsd.org> Cc: svn-src-all@freebsd.org, svn-src-head@freebsd.org, FreeBSD Ports <freebsd-ports@freebsd.org> Subject: Re: svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt Message-ID: <CAALwa8nMoaO64_YRFxGTXR42AJQyqaTq=jSLBB6sp6pfPcw8%2BA@mail.gmail.com> In-Reply-To: <20170321064154.GL23308@FreeBSD.org> References: <201703210639.v2L6dnRf055522@repo.freebsd.org> <20170321064154.GL23308@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Mar 21, 2017 at 7:41 AM, Gleb Smirnoff <glebius@freebsd.org> wrote: > Hi! > > This change is known to break a ton of ports. More than 100 if > counting depends. I'm sorry for that and I already started to fix > them. > > Please send all new breakages to me. Hi, Exp-runs should happen before breakage happens, not after. If you already know that it breaks hundreds of ports, please revert and request an exp-run. Antoine (with hat: portmgr) > On Tue, Mar 21, 2017 at 06:39:49AM +0000, Gleb Smirnoff wrote: > T> Author: glebius > T> Date: Tue Mar 21 06:39:49 2017 > T> New Revision: 315662 > T> URL: https://svnweb.freebsd.org/changeset/base/315662 > T> > T> Log: > T> Hide struct inpcb, struct tcpcb from the userland. > T> > T> This is a painful change, but it is needed. On the one hand, we avoid > T> modifying them, and this slows down some ideas, on the other hand we still > T> eventually modify them and tools like netstat(1) never work on next version of > T> FreeBSD. We maintain a ton of spares in them, and we already got some ifdef > T> hell at the end of tcpcb. > T> > T> Details: > T> - Hide struct inpcb, struct tcpcb under _KERNEL || _WANT_FOO. > T> - Make struct xinpcb, struct xtcpcb pure API structures, not including > T> kernel structures inpcb and tcpcb inside. Export into these structures > T> the fields from inpcb and tcpcb that are known to be used, and put there > T> a ton of spare space. > T> - Make kernel and userland utilities compilable after these changes. > T> - Bump __FreeBSD_version. > T> > T> Reviewed by: rrs, gnn > T> Differential Revision: D10018
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8nMoaO64_YRFxGTXR42AJQyqaTq=jSLBB6sp6pfPcw8%2BA>