Date: Wed, 22 Jun 2011 18:27:10 +0100 From: Chris Rees <crees@freebsd.org> To: Henrik Brix Andersen <brix@freebsd.org> Cc: hackers@freebsd.org Subject: Re: CONF class of files Message-ID: <BANLkTikXyB_teVJyzxLfPpm5XJB_1zPs_Q@mail.gmail.com> In-Reply-To: <AE55A6EA-C39F-4167-9C07-FEFDFD0FFD02@freebsd.org> References: <BANLkTinkhTzy9aOw0SzcQWff8p8COrVPNw@mail.gmail.com> <379A724C-4458-4E5C-81E9-CF125666E203@FreeBSD.org> <BANLkTikbF4_CifAzaAOUXYVYxyu8X3po2A@mail.gmail.com> <AE55A6EA-C39F-4167-9C07-FEFDFD0FFD02@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 19 June 2011 10:14, Henrik Brix Andersen <brix@freebsd.org> wrote:
> On Jun 19, 2011, at 10:50, Chris Rees wrote:
>> On 19 June 2011 09:15, Henrik Brix Andersen <brix@freebsd.org> wrote:
>>>
>>> On Jun 17, 2011, at 18:40, Chris Rees wrote:
>>>> Macros are being tested for bsd.port.mk that use a new class of files,
>>>> in the same vein as the BINOWN variables I have introduced CONFOWN,
>>>> CONFGRP, CONFMODE and CONFDIR.
>>>>
>>>> Please would someone review and give an opinion on [1]?
>>>
>>> Shouldn't $CONFDIR be set to ${PREFIX}/etc/ instead of /etc?
>>>
>>> Also, if we define $CONFDIR, we should use it everywhere in bsd.*.mk where we currently use some form of */etc/* - otherwise we will get a mismatch if $CONFDIR is changed from the default.
>>
>> CONFDIR is for base, not ports, just like most other stuff in that
>> file. Have a look at the other DIR variables.
>
> Gah, I was confused by you initial mail mentioning bsd.port.mk.
>
> Rereading the patch, I think it looks good. I'd love to see this go in before 9.0 as well.
>
Hey guys,
Now we've had a bit of interest in this PR, can someone please type
the magic words before the freeze?
Chris
http://www.freebsd.org/cgi/query-pr.cgi?pr=misc/157062
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?BANLkTikXyB_teVJyzxLfPpm5XJB_1zPs_Q>